Some pointers to the code base 1) The search pane l
Bug 1580530 Comment 1 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
Some pointers to the code base: 1) The Search panel is rendered here https://searchfox.org/mozilla-central/rev/a777ff11b6d700a698c61e5bd17e73b044304494/devtools/client/netmonitor/src/components/MonitorPanel.js#180 In this place we need to render the new side bar `NetworkActionBar` not just one panel. The SearchPanel is implemented here: https://searchfox.org/mozilla-central/rev/a777ff11b6d700a698c61e5bd17e73b044304494/devtools/client/netmonitor/src/components/search/SearchPanel.js#37 2) The existing right side bar is represented by `NetworkDetailsPanel` and rendered here: https://searchfox.org/mozilla-central/rev/a777ff11b6d700a698c61e5bd17e73b044304494/devtools/client/netmonitor/src/components/MonitorPanel.js#226 ... and implemented here: https://searchfox.org/mozilla-central/rev/a777ff11b6d700a698c61e5bd17e73b044304494/devtools/client/netmonitor/src/components/NetworkDetailsPanel.js#29 4) The new `NetworkActionBar` should be implemented exactly the same way as `NetworkDetailsPanel`. Based on `Tabbar` require("devtools/client/shared/components/tabs/TabBar") `NetworkDetailsPanel` is using helper `TabboxPanel`, but it looks like it isn't needed for `NetworkActionBar`. Let's try to simplify it here. 6) Here is an example of adding a new panel into the `TabBar` https://searchfox.org/mozilla-central/rev/a777ff11b6d700a698c61e5bd17e73b044304494/devtools/client/netmonitor/src/components/TabboxPanel.js#124-137 We need to append the existing `SearchPanel`. Honza
Some pointers to the code base: 1) The Search panel is rendered here https://searchfox.org/mozilla-central/rev/a777ff11b6d700a698c61e5bd17e73b044304494/devtools/client/netmonitor/src/components/MonitorPanel.js#180 In this place we need to render the new side bar `NetworkActionBar` not just one panel. The SearchPanel is implemented here: https://searchfox.org/mozilla-central/rev/a777ff11b6d700a698c61e5bd17e73b044304494/devtools/client/netmonitor/src/components/search/SearchPanel.js#37 2) The existing right side bar is represented by `NetworkDetailsPanel` (should be renamed to `NetworkDetailsBar` in another bug) and rendered here: https://searchfox.org/mozilla-central/rev/a777ff11b6d700a698c61e5bd17e73b044304494/devtools/client/netmonitor/src/components/MonitorPanel.js#226 ... and implemented here: https://searchfox.org/mozilla-central/rev/a777ff11b6d700a698c61e5bd17e73b044304494/devtools/client/netmonitor/src/components/NetworkDetailsPanel.js#29 4) The new `NetworkActionBar` should be implemented exactly the same way as `NetworkDetailsPanel`. Based on `Tabbar` require("devtools/client/shared/components/tabs/TabBar") `NetworkDetailsPanel` is using helper `TabboxPanel`, but it looks like it isn't needed for `NetworkActionBar`. Let's try to simplify it here. 6) Here is an example of adding a new panel into the `TabBar` https://searchfox.org/mozilla-central/rev/a777ff11b6d700a698c61e5bd17e73b044304494/devtools/client/netmonitor/src/components/TabboxPanel.js#124-137 We need to append the existing `SearchPanel`. Honza
Some pointers to the code base: 1) The Search panel is rendered here https://searchfox.org/mozilla-central/rev/a777ff11b6d700a698c61e5bd17e73b044304494/devtools/client/netmonitor/src/components/MonitorPanel.js#180 In this place we need to render the new side bar `NetworkActionBar` not just one panel. The SearchPanel is implemented here: https://searchfox.org/mozilla-central/rev/a777ff11b6d700a698c61e5bd17e73b044304494/devtools/client/netmonitor/src/components/search/SearchPanel.js#37 2) The existing right side bar is represented by `NetworkDetailsPanel` (should be renamed to `NetworkDetailsBar` in another bug) and rendered here: https://searchfox.org/mozilla-central/rev/a777ff11b6d700a698c61e5bd17e73b044304494/devtools/client/netmonitor/src/components/MonitorPanel.js#226 ... and implemented here: https://searchfox.org/mozilla-central/rev/a777ff11b6d700a698c61e5bd17e73b044304494/devtools/client/netmonitor/src/components/NetworkDetailsPanel.js#29 3) The new `NetworkActionBar` should be implemented exactly the same way as `NetworkDetailsPanel`. Based on `Tabbar` require("devtools/client/shared/components/tabs/TabBar") `NetworkDetailsPanel` is using helper `TabboxPanel`, but it looks like it isn't needed for `NetworkActionBar`. Let's try to simplify it here. 4) Here is an example of adding a new panel into the `TabBar` https://searchfox.org/mozilla-central/rev/a777ff11b6d700a698c61e5bd17e73b044304494/devtools/client/netmonitor/src/components/TabboxPanel.js#124-137 We need to append the existing `SearchPanel`. Honza