(In reply to :Gijs (he/him) from comment #5) > I don't understand what the webbrowserpersist changes have to do with this error. AFAICT the answer should be "nothing". What needs to be figured out is why `file` is not a valid file when calling `getURLSpecFromFile`. The saving of photos in abCommon was already updated in bug 1519732, and I don't see other download/persist usage in abCard.js off-hand. I suspect that what's needed is a second regression window since the fix in bug 1519732, which presumably will point to a different bug. Okay, I tried further investigation. #1 When switching from "Generic Photo" to "On this Computer", a console error appears Trying to switch to "On the Web" doesn't work at all and leaves the first radio option selected. https://hg.mozilla.org/comm-central/pushloghtml?startdate=2018-04-05+20%3A00%3A00&enddate=2018-04-28+04%3A21%3A16 https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=7b40283bf1c7a2a3e6a8a5d00156a2f506&tochange=8b2c1fc3d6c348f053fe33a478fa3b1ddb5eb8a6 #2 Click "Browse" button of "On this Computer" row > select an image file, Does not work and leaves the first radio option selected. https://hg.mozilla.org/comm-central/pushloghtml?fromchange=62bf2165d66e05948aed74b548f377dbc6347ce7&tochange=8a97b511da2100d600434e20391bdb48176d850a https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=8fd4efa75b558406390c316a7e4d1fc288715866&tochange=29e9dde37bd231a94959394554154ede52670c65
Bug 1581253 Comment 6 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
(In reply to :Gijs (he/him) from comment #5) > I don't understand what the webbrowserpersist changes have to do with this error. AFAICT the answer should be "nothing". What needs to be figured out is why `file` is not a valid file when calling `getURLSpecFromFile`. The saving of photos in abCommon was already updated in bug 1519732, and I don't see other download/persist usage in abCard.js off-hand. I suspect that what's needed is a second regression window since the fix in bug 1519732, which presumably will point to a different bug. Okay, I tried further investigation. #1 When switching from "Generic Photo" to "On this Computer", a console error appears. Trying to switch to "On the Web" doesn't work at all and leaves the first radio option selected. https://hg.mozilla.org/comm-central/pushloghtml?startdate=2018-04-05+20%3A00%3A00&enddate=2018-04-28+04%3A21%3A16 https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=7b40283bf1c7a2a3e6a8a5d00156a2f506&tochange=8b2c1fc3d6c348f053fe33a478fa3b1ddb5eb8a6 #2 Click "Browse" button of "On this Computer" row > select an image file, Does not work and leaves the first radio option selected. https://hg.mozilla.org/comm-central/pushloghtml?fromchange=62bf2165d66e05948aed74b548f377dbc6347ce7&tochange=8a97b511da2100d600434e20391bdb48176d850a https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=8fd4efa75b558406390c316a7e4d1fc288715866&tochange=29e9dde37bd231a94959394554154ede52670c65