Bug 1582187 Comment 16 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

The issue bug 1566084 is suppose to address was handled on version increase by the add-ons manager's incompatible add-on check UI that was shown on startup and was removed without a replacement. So, it handled it when there was an update as well as when there was an upgrade due to installing a newer version. Bug 1566084 as described will never handle the upgrade scenario when installing a newer version since that happens without using app update.

Also, this issue affects beta which wouldn't have a version change afaik so for bug 1566084 to fix this bug app update would have to signal the add-ons manager that an update was available even for updates without a version change. This seems overkill especially for nightly builds which currently update twice a day.

I personally don't think bug 1566084 is a good fix for this bug due to both of these issues.
The issue bug 1566084 is suppose to address used to be handled onFirefox version increase by the add-ons manager's incompatible add-on check UI that was shown on startup and was removed without a replacement. So, it handled it when there was an update as well as when there was an upgrade due to installing a newer version. Bug 1566084 as described will never handle the upgrade scenario when installing a newer version since that happens without using app update.

Also, this issue affects beta which wouldn't have a version change afaik so for bug 1566084 to fix this bug app update would have to signal the add-ons manager that an update was available even for updates without a version change. This seems overkill especially for nightly builds which currently update twice a day.

I personally don't think bug 1566084 is a good fix for this bug due to both of these issues.
The issue bug 1566084 is suppose to address used to be handled on Firefox version change to a newer version by the add-ons manager's incompatible add-on check UI that was shown on startup and was removed without a replacement. So, it handled it when there was an update as well as when there was an upgrade due to installing a newer version. Bug 1566084 as described will never handle the upgrade scenario when installing a newer version since that happens without using app update.

Also, this issue affects beta which wouldn't have a version change afaik so for bug 1566084 to fix this bug app update would have to signal the add-ons manager that an update was available even for updates without a version change. This seems overkill especially for nightly builds which currently update twice a day.

I personally don't think bug 1566084 is a good fix for this bug due to both of these issues.

Back to Bug 1582187 Comment 16