Bug 1582866 Comment 5 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

I just looked the attached test extension and I noticed that it does embed a variables view in the sidebar (and not an extension page as I assumed in Comment 4).

The shared container for all the devtools inspector sidebar types that an extension can register is defined by `devtools/client/inspector/extensions/components/ExtensionSidebar.js` and the class name of that container element is "extension-sidebar" (and it also have the class name "inspector-tabpanel"):

https://searchfox.org/mozilla-central/rev/e3fc8f8970491aef14d3212b2d052942f4d29818/devtools/client/inspector/extensions/components/ExtensionSidebar.js#86

(and [this component also have a style property set from the React render method](https://searchfox.org/mozilla-central/rev/e3fc8f8970491aef14d3212b2d052942f4d29818/devtools/client/inspector/extensions/components/ExtensionSidebar.js#92-94)).
I just looked the attached test extension and I noticed that it does embed a variables view in the sidebar (and not an extension page as I assumed in Comment 4).

The shared container for all the devtools inspector sidebar types that an extension can register is defined by `devtools/client/inspector/extensions/components/ExtensionSidebar.js` and the class name of that container element is "extension-sidebar" (and it also have the class name "inspector-tabpanel"):

https://searchfox.org/mozilla-central/rev/e3fc8f8970491aef14d3212b2d052942f4d29818/devtools/client/inspector/extensions/components/ExtensionSidebar.js#86

This component has also a `style` property set from the React render method](https://searchfox.org/mozilla-central/rev/e3fc8f8970491aef14d3212b2d052942f4d29818/devtools/client/inspector/extensions/components/ExtensionSidebar.js#92-94)), and so the following diff should be one way to apply on this frame the css styling fixes mentioned in comment 0:

```
diff --git a/devtools/client/inspector/extensions/components/ExtensionSidebar.js b/devtools/client/inspector/extensions/components/ExtensionSidebar.js
--- a/devtools/client/inspector/extensions/components/ExtensionSidebar.js
+++ b/devtools/client/inspector/extensions/components/ExtensionSidebar.js
@@ -91,6 +91,7 @@ class ExtensionSidebar extends PureCompo
         className,
         style: {
           height: "100%",
+          overflow: "auto",
         },
       },
       sidebarContentEl
```

Back to Bug 1582866 Comment 5