Bug 1584780 Comment 6 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Brian Grinstead [:bgrins] from comment #5)
> FYI: I believe this bug means that these panels aren't tested in automation, since before Bug 1582530 landed there were try pushes that would have crashed had it hit this case.

Those try pushes didn’t include asserts for the display: flex cases, since a lot of the CSS that was caught by that display:flex didn’t require any change after unblockification from manual testing.

We can potentially revisit this by re-applying the assert, fixing all the cases one-by-one, removing the assert and then unapplying the “fixes” that make no differences.
(In reply to Brian Grinstead [:bgrins] from comment #5)
> FYI: I believe this bug means that these panels aren't tested in automation, since before Bug 1582530 landed there were try pushes that would have crashed had it hit this case.

Those try pushes didn’t include asserts for the display: flex cases, since a lot of the CSS that was caught by that display:flex assert didn’t require any change after unblockification from manual testing.

We can potentially revisit this by re-applying the assert, fixing all the cases one-by-one, removing the assert and then unapplying the “fixes” that make no differences.

Back to Bug 1584780 Comment 6