Bug 1585921 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Every so often someone adds a container of GC things that doesn't have the correct barriers which then results in follow on crashes and possible security vulnerabilities.  This is not surprising as these things are hard to use and the correct approach is not always obvious.

We should try and improve this situation.   Some possibilities:
 - add static asserts when things are mis-used (e.g. when creating a GC container of unbarriered pointers) but there are probably exceptions
 - have some kind of linter that warns when new instances of questionable usage are added
 - improve the documentation
Every so often a change adds a container of GC things that doesn't have the correct barriers which then results in follow on crashes and possible security vulnerabilities.  This is not surprising as these things are hard to use and the correct approach is not always obvious.

We should try and improve this situation.   Some possibilities:
 - add static asserts when things are mis-used (e.g. when creating a GC container of unbarriered pointers) but there are probably exceptions
 - have some kind of linter that warns when new instances of questionable usage are added
 - improve the documentation

Back to Bug 1585921 Comment 0