Doing further investigation as well after discussing with MattN the other night, I think the problem here is from the timer and it applies only to the scenario in which the door-hanger is in the dismissed state. mnoorenberghe 12:43 AM: >that has been the behaviour of the pwmgr doorhanger for a long time >https://searchfox.org/mozilla-central/rev/5cb522c7baba24e55874809e0e206b001494c1e9/toolkit/components/passwordmgr/LoginManagerPrompter.jsm#1298" (In reply to Matthew N. [:MattN] (PM me if requests are blocking you) from comment #5) > This is only data loss if the user already has an empty-username login saved for the site, right? In this case, on the update door-hanger will not be in dismissed state, it will be displayed hence it will persist on reload or redirect. Here's reduced STR.: (use clean profile or delete all about:login entries for the test site) ###### Case A: (proper functionality) 1. Open https://bugs.mattn.ca/pwmgr/login_and_change_form.html 2. In "Login form" input u/p and press "log in" / save credentials. 3. Open in new tab https://bugs.mattn.ca/pwmgr/login_and_change_form.html 4. Delete the autofill entries, leaving only the autofilled current password in the "Password change form". 5. In the "Password change form" generate secure passwords for both fields and press "change password". A.R. On "change password", redirects to success.html page, blue key /dismissed door-hanger is present. ###### Case B: (dismissed update door-hanger gone) - same steps as in case A, just introduces delay at str 5 1. Open https://bugs.mattn.ca/pwmgr/login_and_change_form.html 2. In "Login form" input u/p and press "log in" / save credentials. 3. Open in new tab https://bugs.mattn.ca/pwmgr/login_and_change_form.html 4. Delete the autofill entries, leaving only the autofilled current password in the "Password change form". 5. In the "Password change form" generate secure passwords for both fields and wait(20s) then press "change password". A.R. On "change password", redirects to success.html page, blue key /dismissed door-hanger is gone. So, AIUI, I guess this explains why we caught this issue so late and why we thought initially it is intermittent.
Bug 1586304 Comment 8 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
Doing further investigation as well after discussing with MattN the other night, I think the problem here is from the timer and it applies only to the scenario in which the door-hanger is in the dismissed state. mnoorenberghe 12:43 AM: >that has been the behaviour of the pwmgr doorhanger for a long time >https://searchfox.org/mozilla-central/rev/5cb522c7baba24e55874809e0e206b001494c1e9/toolkit/components/passwordmgr/LoginManagerPrompter.jsm#1298" (In reply to Matthew N. [:MattN] (PM me if requests are blocking you) from comment #5) > This is only data loss if the user already has an empty-username login saved for the site, right? In this case, on the update door-hanger will not be in dismissed state, it will be displayed hence it will persist on reload or redirect. -- the issue will be caught most reliable on change password forms or forms which miss the username Here's reduced STR.: (use clean profile or delete all about:login entries for the test site) ###### Case A: (proper functionality) 1. Open https://bugs.mattn.ca/pwmgr/login_and_change_form.html 2. In "Login form" input u/p and press "log in" / save credentials. 3. Open in new tab https://bugs.mattn.ca/pwmgr/login_and_change_form.html 4. Delete the autofill entries, leaving only the autofilled current password in the "Password change form". 5. In the "Password change form" generate secure passwords for both fields and press "change password". A.R. On "change password", redirects to success.html page, blue key /dismissed door-hanger is present. ###### Case B: (dismissed update door-hanger gone) - same steps as in case A, just introduces delay at str 5 1. Open https://bugs.mattn.ca/pwmgr/login_and_change_form.html 2. In "Login form" input u/p and press "log in" / save credentials. 3. Open in new tab https://bugs.mattn.ca/pwmgr/login_and_change_form.html 4. Delete the autofill entries, leaving only the autofilled current password in the "Password change form". 5. In the "Password change form" generate secure passwords for both fields and wait(20s) then press "change password". A.R. On "change password", redirects to success.html page, blue key /dismissed door-hanger is gone. So, AIUI, I guess this explains why we caught this issue so late and why we thought initially it is intermittent.
Doing further investigation as well after discussing with MattN the other night, I think the problem here is from the timer and it applies only to the scenario in which the door-hanger is in the dismissed state. mnoorenberghe 12:43 AM: >that has been the behaviour of the pwmgr doorhanger for a long time >https://searchfox.org/mozilla-central/rev/5cb522c7baba24e55874809e0e206b001494c1e9/toolkit/components/passwordmgr/LoginManagerPrompter.jsm#1298" (In reply to Matthew N. [:MattN] (PM me if requests are blocking you) from comment #5) > This is only data loss if the user already has an empty-username login saved for the site, right? In this case, on the update door-hanger will not be in dismissed state, it will be displayed hence it will persist on reload or redirect. -- the issue will be caught mostly on change password forms or forms which miss the username Here's reduced STR.: (use clean profile or delete all about:login entries for the test site) ###### Case A: (proper functionality) 1. Open https://bugs.mattn.ca/pwmgr/login_and_change_form.html 2. In "Login form" input u/p and press "log in" / save credentials. 3. Open in new tab https://bugs.mattn.ca/pwmgr/login_and_change_form.html 4. Delete the autofill entries, leaving only the autofilled current password in the "Password change form". 5. In the "Password change form" generate secure passwords for both fields and press "change password". A.R. On "change password", redirects to success.html page, blue key /dismissed door-hanger is present. ###### Case B: (dismissed update door-hanger gone) - same steps as in case A, just introduces delay at str 5 1. Open https://bugs.mattn.ca/pwmgr/login_and_change_form.html 2. In "Login form" input u/p and press "log in" / save credentials. 3. Open in new tab https://bugs.mattn.ca/pwmgr/login_and_change_form.html 4. Delete the autofill entries, leaving only the autofilled current password in the "Password change form". 5. In the "Password change form" generate secure passwords for both fields and wait(20s) then press "change password". A.R. On "change password", redirects to success.html page, blue key /dismissed door-hanger is gone. So, AIUI, I guess this explains why we caught this issue so late and why we thought initially it is intermittent.