Bug 1586784 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
In bug 1568857 we started making the layout-view panel display correct information even when the selected node is in an oop iframe.
However there's a number of places in the code that still need to be changed to work correctly with oop iframes.

  devtools/client/inspector/boxmodel/box-model.js
    203	`const offsetParent = await inspectorFront.walker.getOffsetParent(`

  devtools/client/inspector/rules/views/text-property-editor.js
    361	`const layoutInspector = await this.ruleView.inspector.walker.getLayoutInspector();`

  devtools/client/inspector/shared/highlighters-overlay.js
    111	`this.walker.on("display-change", this.onDisplayChange);`
    564	`const parentGridNode = await this.walker.getParentGridNode(node);`
    675	`const parentGridNode = await this.walker.getParentGridNode(`
    877	`const rootNode = await this.walker.getRootNode();`
    878	`const nodeFront = await this.walker.querySelector(rootNode, selector);`
    1481	`this.walker.off("display-change", this.onDisplayChange);`
Revision 1 by
on 
In bug 1568857 we started making the layout-view panel display correct information even when the selected node is in an oop iframe.
However there's a number of places in the code that still need to be changed to work correctly with oop iframes.

  devtools/client/inspector/boxmodel/box-model.js
    203	`const offsetParent = await inspectorFront.walker.getOffsetParent(`
We should instead get the walker contextual to the currently selected node here.

  devtools/client/inspector/rules/views/text-property-editor.js
    361	`const layoutInspector = await this.ruleView.inspector.walker.getLayoutInspector();`
We should instead get the walker contextual to the currently selected node here.

  devtools/client/inspector/shared/highlighters-overlay.js
    111	`this.walker.on("display-change", this.onDisplayChange);`
    1481	`this.walker.off("display-change", this.onDisplayChange);`
We will probably need to listen to this on all walkers here.
    564	`const parentGridNode = await this.walker.getParentGridNode(node);`
    675	`const parentGridNode = await this.walker.getParentGridNode(`
We should instead get the walker contextual to the currently selected node here.
    877	`const rootNode = await this.walker.getRootNode();`
    878	`const nodeFront = await this.walker.querySelector(rootNode, selector);`
Not sure what to do here, but if the stored state is for a node inside a remote iframe, this won't work.

Back to Bug 1586784 Comment 0