Bug 1586986 Comment 2 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
(In reply to Hiroyuki Ikezoe (:hiro) from comment #1)
> :snorp or Sebastian, using CoordinatorLayout is the way to go for the dynamic toolbar? If so, we can assume the size comes from surfaceChanged is including the toolbar.  (But we need a way to tell whether it's dynamic or static).  Also I am wondering how Chrome implements the dynamic toolbar in their _ChromeView_.

Probably, in such cases GeckoView should calls [onBoundsChanged](https://searchfox.org/mozilla-central/rev/5cb522c7baba24e55874809e0e206b001494c1e9/mobile/android/geckoview/src/main/java/org/mozilla/geckoview/GeckoSession.java#5355) with the size reducing the toolbar height as we've been doing for Fennec.
Revision 1 by
on 
(In reply to Hiroyuki Ikezoe (:hiro) from comment #1)
> :snorp or Sebastian, using CoordinatorLayout is the way to go for the dynamic toolbar? If so, we can assume the size comes from surfaceChanged is including the toolbar.  (But we need a way to tell whether it's dynamic or static).  Also I am wondering how Chrome implements the dynamic toolbar in their _ChromeView_.

Probably, in such cases GeckoView should call [onBoundsChanged](https://searchfox.org/mozilla-central/rev/5cb522c7baba24e55874809e0e206b001494c1e9/mobile/android/geckoview/src/main/java/org/mozilla/geckoview/GeckoSession.java#5355) with the size reducing the toolbar height as we've been doing for Fennec.

Back to Bug 1586986 Comment 2