Bug 1587722 Comment 19 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to David Teller [:Yoric] (please use "needinfo") from comment #18)
> Won't we get the memory information after cleanup instead of the memory information before cleanup?

IIRC we don't actually kill the content process until we're done with crash reporting. The `ReadExceptionTimeAnnotations()` function is called from within Breakpad's child-crash callback and I'm fairly sure that the process doesn't get killed until after it returns because I've seen cases where we hit a second exception in the same content process (but on a different thread) while we were processing the first one in that function.

So in theory the memory scenario should be pretty much the same. The only difference I can think of is on Windows the `AvailableVirtualMemory` information is process-specific; all the other fields should be global measures.
(In reply to David Teller [:Yoric] (please use "needinfo") from comment #18)
> Won't we get the memory information after cleanup instead of the memory information before cleanup?

IIRC we don't actually kill the content process until we're done with crash reporting. The `ReadExceptionTimeAnnotations()` function is called from within Breakpad's child-crash callback and I'm fairly sure that the process doesn't get killed until after it returns because I've seen cases where we hit a second exception in the same content process (but on a different thread) while we were processing the first one in that function.

So in theory the memory scenario should be pretty much the same. The only difference I can think of is on Windows the `AvailableVirtualMemory` information is process-specific; all the other fields should be global measurements.

Back to Bug 1587722 Comment 19