Bug 1588874 Comment 3 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
(In reply to Ian Neal from comment #2)
> Comment on attachment 9102849 [details] [diff] [review]
> >-#ifndef XP_MACOSX
> >-        if (!this._doResumeSession()) {
> >-#endif
> >+        if (AppConstants.platform == "macosx" || !this._doResumeSession()) {
> Shouldn't this be != rather than == ?
No, the old code always ran this block on the Mac rather than the `else` block which was `#ifdef`'d out. (Might it be clearer to switch the blocks around and use `if (AppConstants.platform != "macosx" && this._doResumeSession())`?
Revision 1 by
on 
(In reply to Ian Neal from comment #2)
> Comment on attachment 9102849 [details] [diff] [review]
> >```
> >-#ifndef XP_MACOSX
> >-        if (!this._doResumeSession()) {
> >-#endif
> >+        if (AppConstants.platform == "macosx" || !this._doResumeSession()) {
> >```
> Shouldn't this be != rather than == ?
No, the old code always ran this block on the Mac rather than the `else` block which was `#ifdef`'d out. (Might it be clearer to switch the blocks around and use `if (AppConstants.platform != "macosx" && this._doResumeSession())`?

Back to Bug 1588874 Comment 3