(In reply to Rohit Awate from comment #17) > Thanks! I tried `hg update` followed by `hg commit --amend`, but it says `abort: cannot amend changeset with children`. > I tried another way on a dummy repository: `hg strip --keep -r .` which removes the last commit and then `hg commit --amend`. This did work. Do you think this will work well with Phabricator and if it is a good way? I think that will be fine. moz-phab should update the first revision. If it does create a new revision we can just close the first two and no harm is done. > Also, would pushing this patch to Phabricator remove the duplicate patch I had created before on there? (#D50904, specifically) No, but you can just 'abandon' the second patch on Phabricator (look for the `Add Action...` box). > I'm sorry for asking these really stupid questions but I don't want to mess up on Phabricator again. Really appreciate your patience and help! No problem! Thanks for working on this. You can also ask questions in the #jsapi channel on Mozilla's IRC channel.
Bug 1589072 Comment 18 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
(In reply to Rohit Awate from comment #17) > Thanks! I tried `hg update` followed by `hg commit --amend`, but it says `abort: cannot amend changeset with children`. > I tried another way on a dummy repository: `hg strip --keep -r .` which removes the last commit and then `hg commit --amend`. This did work. Do you think this will work well with Phabricator and if it is a good way? I think that will be fine. moz-phab should update the first revision. If it does create a new revision we can just close the first two and no harm is done. > Also, would pushing this patch to Phabricator remove the duplicate patch I had created before on there? (#D50904, specifically) No, but you can just 'abandon' the second patch on Phabricator (look for the `Add Action...` box). > I'm sorry for asking these really stupid questions but I don't want to mess up on Phabricator again. Really appreciate your patience and help! No problem! Thanks for working on this. You can also ask questions in the #jsapi channel on Mozilla's IRC server.