Bug 1590034 Comment 5 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
(In reply to Christian Holler (:decoder) from comment #3)
> `MOZ_CRASH` messages only print in debug builds, so this is going to be a problem.
> 
> We could make `MOZ_CRASH` print its message in debug or fuzzing builds, I wanted to make this change anyway. Now we have another reason to do so. I'll file a bug.

Yeah, I just fixed that in the patch, because we also need this printing in opt builds for the jit-test harness and those shell builds not all fuzzing builds...
Revision 1 by
on 
(In reply to Christian Holler (:decoder) from comment #3)
> `MOZ_CRASH` messages only print in debug builds, so this is going to be a problem.

Yeah, I just fixed that in the patch, because we also need this printing in opt builds for the jit-test harness and those shell builds not all fuzzing builds...
Revision 2 by
on 
(In reply to Christian Holler (:decoder) from comment #3)
> `MOZ_CRASH` messages only print in debug builds, so this is going to be a problem.

Yeah, I just fixed that in the patch, because we also need this printing in opt builds for the jit-test harness and those shell builds are not all fuzzing builds...

Back to Bug 1590034 Comment 5