Bug 1591199 Comment 2 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Yeah, this is because we're firing the signalingstate event from c++, and then jumping to JS, where we update the local SDP type:

https://searchfox.org/mozilla-central/rev/74cc0f4dce444fe0757e2a6b8307d19e4d0e0212/media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.cpp#1352-1353

We cannot just switch the order here, because the sLD needs to resolve after the signalingstate event. We probably need to get rid of this _pendingRole stuff and modify the webidl so PeerConnectionImpl gives us the SDP _and_ the type, bot just the SDP.
Yeah, this is because we're firing the signalingstate event from c++, and then jumping to JS, where we update the local SDP type:

https://searchfox.org/mozilla-central/rev/74cc0f4dce444fe0757e2a6b8307d19e4d0e0212/media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.cpp#1352-1353

We cannot just switch the order here, because the sLD needs to resolve after the signalingstate event. We probably need to get rid of this _pendingRole stuff and modify the webidl so PeerConnectionImpl gives us the SDP _and_ the type, not just the SDP.

Back to Bug 1591199 Comment 2