Bug 1595046 Comment 24 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
I just updated my C++. We now use `Maybe<JS::Value>` to differentiate between "we don't have an exception value available" and `undefined`. Before these two cases were just both undefined. I also add `hasException` to `nsIScriptError`.
Furthermore we now support saving the exception value for main-thread promise rejections! I actually think the patch is already in a pretty good state now.
Revision 1 by
on 
I just updated my C++ patch. We now use `Maybe<JS::Value>` to differentiate between "we don't have an exception value available" and `undefined`. Before these two cases were just both undefined. I also add `hasException` to `nsIScriptError`.
Furthermore we now support saving the exception value for main-thread promise rejections! I actually think the patch is already in a pretty good state now.
Revision 2 by
on 
I just updated my C++ patch. We now use `Maybe<JS::Value>` to differentiate between "we don't have an exception value available" and `undefined`. Before these two cases were both just `undefined`. I also added `hasException` to `nsIScriptError` for this.
Furthermore we now support saving the exception value for main-thread promise rejections! I actually think the patch is already in a pretty good state. It's probably time soon to get some feedback on the basic approach of this patch.

Back to Bug 1595046 Comment 24