Bug 1595747 Comment 5 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
> So are we not passing the aContext? But the patches in bug 1589270 are cpp only so what do we need to update in TB?

That is a good question.  Presumably the relevant call to Show() is at <https://searchfox.org/mozilla-central/rev/e7c61f4a68b974d5fecd216dc7407b631a24eb8f/uriloader/exthandler/nsExternalHelperAppService.cpp#1689>?  It would be good to verify whether it is.

If it is, then it sounds like `GetDialogParent` returned null.  And if that's the case, it's worth trying to figure out why.  Most importantly, what are `mWindowContext` and `mBrowsingContext` in this case?
Revision 1 by
on 
> So are we not passing the aContext? But the patches in bug 1589270 are cpp only so what do we need to update in TB?

That is a good question.  Presumably the relevant call to Show() is at <https://searchfox.org/mozilla-central/rev/e7c61f4a68b974d5fecd216dc7407b631a24eb8f/uriloader/exthandler/nsExternalHelperAppService.cpp#1689>?  It would be good to verify whether it is.

If it is, then it sounds like `GetDialogParent` returned null.  And if that's the case, it's worth trying to figure out why.  Most importantly, what are `mWindowContext` and `mBrowsingContext` in this case in <https://searchfox.org/mozilla-central/rev/e7c61f4a68b974d5fecd216dc7407b631a24eb8f/uriloader/exthandler/nsExternalHelperAppService.cpp#1495-1513>?

Back to Bug 1595747 Comment 5