Some additional notes as well on other things that need to be fixed - when I created `CreateLoadInfo()` here https://searchfox.org/mozilla-central/source/docshell/shistory/nsISHEntry.idl#422, we decided to set the shentry on the nsDocShellLoadState in `SHEntryChild::CreateLoadInfo` instead, when session history in parent in enabled, to avoid (de)serializing the entry. With session history in parent disabled, this path https://searchfox.org/mozilla-central/rev/131338e5017bc0283d86fb73844407b9a2155c98/docshell/shistory/SHEntryChild.cpp#991-993 is never invoked and thus we never set it. I should fix this as well.
Bug 1596776 Comment 4 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
Some additional notes as well on other things that need to be fixed - when I created `CreateLoadInfo()` here https://searchfox.org/mozilla-central/rev/131338e5017bc0283d86fb73844407b9a2155c98/docshell/shistory/nsISHEntry.idl#422, we decided to set the shentry on the `nsDocShellLoadState` in `SHEntryChild::CreateLoadInfo` instead, when session history in parent in enabled, to avoid (de)serializing the entry. With session history in parent disabled, this path https://searchfox.org/mozilla-central/rev/131338e5017bc0283d86fb73844407b9a2155c98/docshell/shistory/SHEntryChild.cpp#991-993 is never invoked and thus we never set it. I should fix this as well.