Bug 1597131 Comment 2 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Review of attachment 9109402 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good overall.  All but one removal seems fine to me from looking at the code and testing out the UI.  I think we should keep that `dragCenter-image` feature in the today pane working in this bug, and remove it in its own bug if we're going to do that.  (I'm not sure how much value it adds.)

::: calendar/lightning/content/messenger-overlay-sidebar.xul
@@ +1769,5 @@
>                      <label id="datevalue-label" class="dateValue"
>                             ondblclick="TodayPane.onDoubleClick(event);"
>                             onmousedown="TodayPane.onMousedown(event);"/>
>                    </hbox>
> +                  <hbox flex="1" pack="center" align="center">

I found that without the `mousethrough="always"` here the `dragCenter-image` functionality didn't work.
Review of attachment 9109402 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good overall.  All but one removal seems fine to me from looking at the code and testing out the UI.  I think we should keep that `dragCenter-image` feature in the today pane working in this bug, and remove it in its own bug if we're going to do that.  That way we could remove all the code related to it.  (I'm not sure how much value it adds.)

::: calendar/lightning/content/messenger-overlay-sidebar.xul
@@ +1769,5 @@
>                      <label id="datevalue-label" class="dateValue"
>                             ondblclick="TodayPane.onDoubleClick(event);"
>                             onmousedown="TodayPane.onMousedown(event);"/>
>                    </hbox>
> +                  <hbox flex="1" pack="center" align="center">

I found that without the `mousethrough="always"` here the `dragCenter-image` functionality didn't work.

Back to Bug 1597131 Comment 2