Bugzilla

(In reply to Chris Peterson [:cpeterson] from comment #5)
> (In reply to Stephen A Pohl [:spohl] from comment #3)
> > > Called from Cocoa code here:
> > >   - https://searchfox.org/mozilla-central/rev/6566d92dd46417a2f57e75c515135ebe84c9cef5/toolkit/xre/MacApplicationDelegate.mm#174
> > >   - - (BOOL) applicationShouldHandleReopen: (NSApplication*)theApp hasVisibleWindows: (BOOL)flag
> > >   - Can’t find any callers to that though.
> > 
> > This can be called by the OS[1]. Does this help?
> 
> Stephen, does this GetNativeWindowPointerFromDOMWindow code break with Fission enabled?

I wouldn't know off-hand.

> If this code is broken with Fission, fixing it blocks enabling Fission is Nightly and a Cocoa widget engineer should prioritize (or delegate) the fix accordingly.

I question the approach here. Cocoa widget engineers with spare cycles are hard to come by. Shouldn't we designate one or two experts in `nsIDocShellTreeItem` replacements and have them go through the code base to make these replacements across the board? The code here isn't doing anything that isn't being done elsewhere in the code base. If it helps move things along, I'm going to post a patch that uses the same approach as `WidgetUtils::DOMWindowToWidget`. Once someone fixes the use of `nsIDocShellTreeItem` there, this bug will disappear too.

(In reply to Chris Peterson [:cpeterson] from comment #5)
> (In reply to Stephen A Pohl [:spohl] from comment #3)
> > > Called from Cocoa code here:
> > >   - https://searchfox.org/mozilla-central/rev/6566d92dd46417a2f57e75c515135ebe84c9cef5/toolkit/xre/MacApplicationDelegate.mm#174
> > >   - - (BOOL) applicationShouldHandleReopen: (NSApplication*)theApp hasVisibleWindows: (BOOL)flag
> > >   - Can’t find any callers to that though.
> > 
> > This can be called by the OS[1]. Does this help?
> 
> Stephen, does this GetNativeWindowPointerFromDOMWindow code break with Fission enabled?

I wouldn't know off-hand.

> If this code is broken with Fission, fixing it blocks enabling Fission is Nightly and a Cocoa widget engineer should prioritize (or delegate) the fix accordingly.

I question the approach here. Cocoa widget engineers with spare cycles are hard to come by. Shouldn't we designate one or two experts in `nsIDocShellTreeItem` replacements and have them go through the code base to make these replacements across the board? The code here isn't doing anything that isn't being done elsewhere in the code base. If it helps move things along, I'm going to post a patch that uses `WidgetUtils::DOMWindowToWidget`. Once someone fixes the use of `nsIDocShellTreeItem` there, this bug will disappear too.