Bug 1599278 Comment 3 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
(In reply to :ehsan akhgari from comment #1)
> FWIW those tests _were_ already disabled on Fission before that bug, even though the annotations don't immediately make you believe so, see the second paragraph of [this comment](https://bugzilla.mozilla.org/show_bug.cgi?id=1596832#c0).  As far as fission is concerned, bug 1596832 didn't enable or disable any new tests...

Thanks for the correction. In that case, we can use this bug to fix the browser_subResources.js tests (and not just re-enable them).

(In reply to :ehsan akhgari from comment #2)
> (BTW this means [all of these tests](https://searchfox.org/mozilla-central/search?q=skip-if.*serviceworker_e10s&case=false&regexp=true&path=) are disabled on Fission.  I wonder if the Fission team is keeping track of these tests...)

@ kmag: should we be testing Fission with serviceworker_e10s enabled? I don't see any of the mochitests skipped for `serviceworker_e10s` in our Fission mochitest spreadsheet:

https://docs.google.com/spreadsheets/d/1kjp32JTuB4axM3wKx0iIYL2Ado-HcyeBhoY-siGxYAs/edit#gid=1560718888
Revision 1 by
on 
(In reply to :ehsan akhgari from comment #1)
> FWIW those tests _were_ already disabled on Fission before that bug, even though the annotations don't immediately make you believe so, see the second paragraph of [this comment](https://bugzilla.mozilla.org/show_bug.cgi?id=1596832#c0).  As far as fission is concerned, bug 1596832 didn't enable or disable any new tests...

Thanks for the correction. In that case, we can use this bug to fix the browser_subResources.js tests (and not just re-enable them).

(In reply to :ehsan akhgari from comment #2)
> (BTW this means [all of these tests](https://searchfox.org/mozilla-central/search?q=skip-if.*serviceworker_e10s&case=false&regexp=true&path=) are disabled on Fission.  I wonder if the Fission team is keeping track of these tests...)

@ kmag: should we be testing Fission with serviceworker_e10s enabled? I don't see any of the mochitests skipped for `skip-if=serviceworker_e10s` in our Fission mochitest spreadsheet:

https://docs.google.com/spreadsheets/d/1kjp32JTuB4axM3wKx0iIYL2Ado-HcyeBhoY-siGxYAs/edit#gid=1560718888

Back to Bug 1599278 Comment 3