Bug 1599887 Comment 22 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
It seems like a regression of  Bug 1589718 . The memory leak happens because wr::WebRenderPipelineInfo is not handled by AsyncImagePipelineManager::NotifyPipelinesUpdated(). Since Bug 1589718, the info is handled only when webrender does rendering in RenderThread::UpdateAndRender(). But the info is valid even when WR does not do rendering.

> video frames to the main window

It seems not directly related to this bug. But there are several points to do it. One simple fix is using mWidget->IsHidden() like CompositorD3D11::BeginFrame().
- https://searchfox.org/mozilla-central/rev/8bc24752246aeac8a9aed566cf1caccf88d97d11/gfx/layers/d3d11/CompositorD3D11.cpp#1145
Revision 1 by
on 
It seems like a regression of  Bug 1589718 . The memory leak happens because wr::WebRenderPipelineInfo is not handled by AsyncImagePipelineManager::NotifyPipelinesUpdated(). Since Bug 1589718 fix, the info is handled only when webrender does rendering in RenderThread::UpdateAndRender(). But the info is valid even when WR does not do rendering.

> video frames to the main window

It seems not directly related to this bug. But there are several points to do it. One simple fix is using mWidget->IsHidden() like CompositorD3D11::BeginFrame().
- https://searchfox.org/mozilla-central/rev/8bc24752246aeac8a9aed566cf1caccf88d97d11/gfx/layers/d3d11/CompositorD3D11.cpp#1145

Back to Bug 1599887 Comment 22