(In reply to Alessandro Castellani (:aleca) from comment #1) > It seems we took care of almost all the various quirks. Hmm, really? At the time of that comment, 4 out of 7 tasks (1, 5, 6, 7) from comment 0 were still outstanding, some of them with several sub-tasks. And there's more which isn't even on the list yet... > It'd be nice to focus on the SHIFT implementation here with the following: > * Shift + Click on a pill will focus all the pills between a previously focused pill and the currently clicked pill. > * Shift + END key should select all pills between a previously focused pill and the last available pill. > * Shift + END key should select all pills between a previously focused pill and the first available pill. So that looks like tasks 1 and 7 from comment 0, covering the most basic cases of a single, contiguous block selection. Unfortunately for feature-completeness, we also need to cover noncontiguous selections involving Ctrl, e.g. cases where user selects random pills in random order, focus is on a satellite pill which isn't selected, and user can add to selection using Ctrl+Shift+Space. In some of such cases it's no longer the focused pill, but the last selected pill which matters (cf. Windows item selection behaviour as seen in Explorer). So it's less trivial than it looks. > Thomas, would you be able to handle this? I'd think so, yes, and will certainly need your input, too. It's a lot of intricate work, which needs real professional working hours to cover all scenarios, so I'll look into this in due course when or if such working hours will be available on my side. In the meantime, I'll offer a patch which fixes Shift+Cursor-right selections involving the last pill, which can be used as a bandaid substitute for Shift+End.
Bug 1602397 Comment 2 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
(In reply to Alessandro Castellani (:aleca) from comment #1) > It seems we took care of almost all the various quirks. Hmm, really? At the time of that comment, 4 out of 7 tasks (1, 5, 6, 7) from comment 0 were still outstanding, some of them with several sub-tasks. And there's more which isn't even on the list yet... > It'd be nice to focus on the SHIFT implementation here with the following: > * Shift + Click on a pill will focus all the pills between a previously focused pill and the currently clicked pill. > * Shift + END key should select all pills between a previously focused pill and the last available pill. > * Shift + END key should select all pills between a previously focused pill and the first available pill. So that looks like tasks 1 and 7 from comment 0, covering the most basic cases of a single, contiguous block selection. Unfortunately for feature-completeness, we also need to cover noncontiguous selections involving Ctrl, e.g. cases where user selects random non-adjacent pills in random order, focus is on a satellite pill which isn't selected, and user can add to selection using Ctrl+Shift+Space. In some of such cases it's no longer the focused pill, but the last selected pill which matters (cf. Windows item selection behaviour as seen in Explorer). So it's less trivial than it looks. > Thomas, would you be able to handle this? I'd think so, yes, and will certainly need your input, too. It's a lot of intricate work, which needs real professional working hours to cover all scenarios, so I'll look into this in due course when or if such working hours will be available on my side. In the meantime, I'll offer a patch which fixes Shift+Cursor-right selections involving the last pill, which can be used as a bandaid substitute for Shift+End.