Current patch attachment 9115847 [details] [diff] [review] in bug 1603563 isn't quite complete... This patch here isn't either, but I'm hoping to have covered the following: ## removing recipient pills with DEL or BACKSPACE ## - all cases and edge cases I could think of - deleting single and multiple selections (enable fast-track single key press consecutive single pill deletions; focus-only after deleting multiple selections of pills) - deleting contiguous and non-contiguous selections - deleting selections where focus is on unselected pill (using Ctrl), combined with any of the above (always keep existing user-focus on unselected pill; cf. Windows Explorer) - deleting first and last pill (which in multiple selections can prevent focusing the expected sibling, but we still have to put focus somewhere) - deleting focused pill - smart focus determination - unmodified navigation with cursor (now selects pills, focus-only is not practical) So this patch overrides the mailwidget.js part of patch attachment 9115847 [details] [diff] [review]. I have not fixed deletion via any other methods (context menu, Ctrl+X, main menu, mouse-click on pill's (x)). I hacked the latter to at least stop deleting selections, which was error-prone and highly confusing (like when you click the (x) on an unselected pill and all selected pills go away - no, we can't do that!) Please try the above scenarios and let me know what you think.
Bug 1602431 Comment 5 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
Current patch attachment 9115847 [details] [diff] [review] in bug 1603563 isn't quite complete... This patch here isn't either, but I'm hoping to have covered the following: ## removing recipient pills with DEL or BACKSPACE ## - all cases and edge cases I could think of - deleting single and multiple selections (enable fast-track single key press consecutive single pill deletions; focus-only after deleting multiple selections of pills) - deleting contiguous and non-contiguous selections - deleting selections where focus is on unselected pill (using Ctrl), combined with any of the above (always keep existing user-focus on unselected pill; cf. Windows Explorer) - deleting first and last pill (which in multiple selections can prevent focusing the expected sibling, but we still have to put focus somewhere) - deleting focused pill - smart focus determination - unmodified navigation with cursor (now selects target pill, focus-only is not practical) So this patch overrides the mailwidget.js part of patch attachment 9115847 [details] [diff] [review]. I have not fixed deletion via any other methods (context menu, Ctrl+X, main menu, mouse-click on pill's (x)). I hacked the latter to at least stop deleting selections, which was error-prone and highly confusing (like when you click the (x) on an unselected pill and all selected pills go away - no, we can't do that!) Please try the above scenarios and let me know what you think.
Current patch attachment 9115847 [details] [diff] [review] in bug 1603563 isn't quite complete... This patch here isn't either, but I'm hoping to have covered the following: ## removing recipient pills with DEL or BACKSPACE ## - all cases and edge cases I could think of - deleting single and multiple selections - enable fast-track, single-key-press consecutive deletions of single pills - focus-only after deleting multiple selections of pills - deleting contiguous and non-contiguous selections - deleting selections where focus is on unselected pill (using Ctrl), combined with any of the above (always keep existing user-focus on unselected pill; cf. Windows Explorer) - deleting first and last pill (which in multiple selections can prevent focusing the expected sibling, but we still have to put focus somewhere) - deleting focused pill - smart focus determination - starting keyboard deletion in either direction on any focused, but unselected pill (now helpfully selects) - unmodified navigation with cursor (now selects target pill, focus-only is not practical) So this patch overrides the mailwidget.js part of patch attachment 9115847 [details] [diff] [review]. I have not fixed deletion via any other methods (context menu, Ctrl+X, main menu, mouse-click on pill's (x)). I hacked the latter to at least stop deleting selections, which was error-prone and highly confusing (like when you click the (x) on an unselected pill and all selected pills go away - no, we can't do that!) Please try the above scenarios and let me know what you think.
Current patch attachment 9115847 [details] [diff] [review] in bug 1603563 isn't quite complete... This patch here isn't either, but I'm hoping to have covered the following: ## Removing recipient pills with DEL or BACKSPACE ## - all cases and edge cases I could think of - deleting single and multiple selections - enable fast-track, single-key-press consecutive deletions of single pills - focus-only after deleting multiple selections of pills - deleting contiguous and non-contiguous selections - deleting selections where focus is on unselected pill (using Ctrl), combined with any of the above (always keep existing user-focus on unselected pill; cf. Windows Explorer) - deleting first and last pill (which in multiple selections can prevent focusing the expected sibling, but we still have to put focus somewhere) - deleting focused pill - smart focus determination - starting keyboard deletion in either direction on any focused, but unselected pill (now helpfully selects) - unmodified navigation with cursor (now selects target pill, focus-only is not practical) So this patch overrides the mailwidget.js part of patch attachment 9115847 [details] [diff] [review]. I have not fixed deletion via any other methods (context menu, Ctrl+X, main menu, mouse-click on pill's (x)). I hacked the latter to at least stop deleting selections, which was error-prone and highly confusing (like when you click the (x) on an unselected pill and all selected pills go away - no, we can't do that!) Please try the above scenarios and let me know what you think.
Current patch attachment 9115847 [details] [diff] [review] in bug 1603563 isn't quite complete... This patch here isn't either, but I'm hoping to have covered the following: ## Removing recipient pills with DEL or BACKSPACE ## - all cases and edge cases I could think of - deleting single and multiple selections - enable fast-track, single-key-press consecutive deletions of single pills - focus-only after deleting multiple selections of pills - deleting contiguous and non-contiguous selections - deleting selections where focus is on unselected pill (using Ctrl), combined with any of the above (always keep existing user-focus on unselected pill; cf. Windows Explorer) - deleting first and last pill (which in multiple selections can prevent focusing the expected sibling, but we still have to put focus somewhere) - deleting focused pill - smart focus determination - starting keyboard deletion in either direction on any focused, but unselected pill (now helpfully selects) - unmodified navigation with cursor (now selects target pill, focus-only is not practical) So this patch overrides the mailwidget.js part of patch attachment 9115847 [details] [diff] [review]. **Disclaimer:** I have not fixed deletion via any other methods (context menu, Ctrl+X, main menu, mouse-click on pill's (x)). I hacked the latter to at least stop deleting selections, which was error-prone and highly confusing (like when you click the (x) on an unselected pill and all selected pills go away - no, we can't do that!) Please try the above scenarios and let me know what you think.
Current patch attachment 9115847 [details] [diff] [review] in bug 1603563 isn't quite complete... This patch here isn't either, but I'm hoping to have covered the following: ## Removing recipient pills with DEL or BACKSPACE ## - all cases and edge cases I could think of - deleting single and multiple selections - enable fast-track, single-key-press consecutive deletions of single pills - focus-only after deleting multiple selections of pills - deleting contiguous and non-contiguous selections - deleting selections where focus is on unselected pill (using Ctrl), combined with any of the above (always keep existing user-focus on unselected pill; cf. Windows Explorer) - deleting first and last pill (which in multiple selections can prevent focusing the expected sibling, but we still have to put focus somewhere) - deleting focused pill - smart focus determination - starting keyboard deletion in either direction on any focused, but unselected pill (now helpfully selects) - unmodified navigation with cursor (now selects target pill, focus-only is not practical) - and the ultimate unthinkable edge case, cross-recipient field multiple non-contiguous selections (yes, you can actually Ctrl+mouse-select random recipients from To, CC, BCC etc. at the same time, and delete them all at once using keyboard, and we still want to get the focus right)... So this patch overrides the mailwidget.js part of patch attachment 9115847 [details] [diff] [review]. **Disclaimer:** I have not fixed deletion via any other methods (context menu, Ctrl+X, main menu, mouse-click on pill's (x)). I hacked the latter to at least stop deleting selections, which was error-prone and highly confusing (like when you click the (x) on an unselected pill and all selected pills go away - no, we can't do that!) Please try the above scenarios and let me know what you think.