(In reply to Alessandro Castellani (:aleca) from comment #14) > Review of attachment 9121409 [details] [diff] [review]: > ----------------------------------------------------------------- Thank you! :-) > Also, and I don't know if it's a local issue, I can't load your patch due to > the special character in the changeset header > `# User Thomas Düllmann <bugzilla2007@duellmann24.net>` Oh yes, sorry, old settings which somehow resurfaced. > ::: mail/base/content/mailWidgets.js > @@ +2057,5 @@ > > + } > > + } > > + } > > + return null; > > + } > > This is a bit verbose and can be simplified by removing the `else` > statements. Awesome, thanks. I'll post a new patch.
Bug 1602431 Comment 17 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
(In reply to Alessandro Castellani (:aleca) from comment #14) > Review of attachment 9121409 [details] [diff] [review]: > ----------------------------------------------------------------- Thank you! :-) > Also, and I don't know if it's a local issue, I can't load your patch due to > the special character in the changeset header > `# User Thomas Düllmann <bugzilla2007@duellmann24.net>` Oh yes, sorry, old settings which somehow resurfaced. ``` > ::: mail/base/content/mailWidgets.js > @@ +2057,5 @@ > > + } > > + } > > + } > > + return null; > > + } ``` > This is a bit verbose and can be simplified by removing the `else` > statements. Awesome, thanks. I'll post a new patch.
(In reply to Alessandro Castellani (:aleca) from comment #14) > Review of attachment 9121409 [details] [diff] [review]: > ----------------------------------------------------------------- Thank you! :-) > Also, and I don't know if it's a local issue, I can't load your patch due to > the special character in the changeset header > `# User Thomas Düllmann <bugzilla2007-(-at-)-duellmann24.net>` Oh yes, sorry, old settings which somehow resurfaced. ``` > ::: mail/base/content/mailWidgets.js > @@ +2057,5 @@ > > + } > > + } > > + } > > + return null; > > + } ``` > This is a bit verbose and can be simplified by removing the `else` > statements. Awesome, thanks. I'll post a new patch.
(In reply to Alessandro Castellani (:aleca) from comment #14) > Review of attachment 9121409 [details] [diff] [review]: > ----------------------------------------------------------------- Thank you! :-) > Also, and I don't know if it's a local issue, I can't load your patch due to > the special character in the changeset header > `# User Thomas Düllmann <bugzilla2007[snip]>` Oh yes, sorry, old settings which somehow resurfaced. ``` > ::: mail/base/content/mailWidgets.js > @@ +2057,5 @@ > > + } > > + } > > + } > > + return null; > > + } ``` > This is a bit verbose and can be simplified by removing the `else` > statements. Awesome, thanks. I'll post a new patch.