Bug 1602901 Comment 5 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Sweet and simple - edit address made easy!

Motivation: We've had several user reports, the latest being duplicate bug 1691255, where users don't know how to edit a pill. Some reporting users are advanced users. Sometimes we make our users suffer for no reason. This fixes the problem by improving discovery without any side effects.

Now the "*delayed* double-click" will also work to edit an address:
- First click selects the pill ("oh, but I want to edit! Let me click again to break that selection!");
**another click on the *selected* pill to edit.**
- Established use pattern for editing selected *item* text (e.g. rename selected file in Windows Explorer) as well as *any selected text* (e.g. Firefox location bar, TB 68 recipient input, any text input).
- Greatly improves ux-discovery.
- Also eases the transition for TB 68 muscle memory (same click pattern).

(In reply to comment #1 and Richard Marti (:Paenglab) from comment #2)
> Yes, like the popup we have for [clicking] addresses in the message header in main window.

FTR: This patch is ***not* prejudicial to having auto-popup menus in the future:**
- Wrt discovery, auto-popup menus only make sense on hover or *first* click, whereas **here we're handling the *second* click on an already selected item.**

Fwiw: Note that 3-pane auto-popups are different because currently, we do *not* allow *selecting* recipients in message reader. Here in composition we *do* support selecting recipient items, so having large auto-popups in composition which will cover other recipients and prevent their selection is a no-go.
Sweet and simple - edit address made easy!

Motivation: We've had several user reports, the latest being duplicate bug 1691255, where users don't know how to edit a pill. Some reporting users are advanced users. Sometimes we make our users suffer for no reason. This fixes the problem by improving discovery without any side effects.

Now the "*delayed* double-click" will also work to edit an address:
- First click selects the pill ("oh, but I want to edit! Let me click again to break that selection!");
**another deliberate click on the *selected* pill to edit.**
- Established use pattern for editing selected *item* text (e.g. rename selected file in Windows Explorer) as well as *any selected text* (e.g. Firefox location bar, TB 68 recipient input, any text input).
- Greatly improves ux-discovery.
- Also eases the transition for TB 68 muscle memory (same click pattern).

(In reply to comment #1 and Richard Marti (:Paenglab) from comment #2)
> Yes, like the popup we have for [clicking] addresses in the message header in main window.

FTR: This patch is ***not* prejudicial to having auto-popup menus in the future:**
- Wrt discovery, auto-popup menus only make sense on hover or *first* click, whereas **here we're handling the *second* click on an already selected item.**

Fwiw: Note that 3-pane auto-popups are different because currently, we do *not* allow *selecting* recipients in message reader. Here in composition we *do* support selecting recipient items, so having large auto-popups in composition which will cover other recipients and prevent their selection is a no-go.
Sweet and simple - edit address made easy!

Motivation: We've had several user reports, the latest being duplicate bug 1691255, where users don't know how to edit a pill. Some reporting users are advanced users. Sometimes we make our users suffer for no reason. This fixes the problem by improving discovery without any side effects.

Now the "*delayed* double-click" will also work to edit an address:
- First click selects the pill ("oh, but I want to edit! Let me click again to break that selection!");
**another deliberate click on the *selected* pill to edit.**
- Established use pattern for editing selected *item* text (e.g. rename selected file in Windows Explorer) as well as *any selected text* (e.g. Firefox location bar, TB 68 recipient input, any text input).
- Greatly improves ux-discovery.
- Also eases the transition for TB 68 muscle memory (same click pattern).

(In reply to comment #1 and Richard Marti (:Paenglab) from comment #2)
> Yes, like the popup we have for [clicking] addresses in the message header in main window.

FTR: This patch is ***not* prejudicial to having auto-popup menus in the future:**
- Wrt discovery and ease of use, auto-popup menus only make sense on hover or *first* click, whereas **here we're handling the *second* click on an already selected item.**

Fwiw: Note that 3-pane auto-popups are different because currently, we do *not* allow *selecting* recipients in message reader. Here in composition we *do* support selecting recipient items, so having large auto-popups in composition which will cover other recipients and prevent their selection is a no-go.

Back to Bug 1602901 Comment 5