Bug 1605305 Comment 4 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
Review of attachment 9117176 [details] [diff] [review]:
-----------------------------------------------------------------

Just a quick look and this breaks the rule that origin header will follow Referrer Policy.
For example, if referrer policy is no-referrer and origin should be null

::: netwerk/protocol/http/nsHttpChannel.cpp
@@ +9838,5 @@
> +        nsContentUtils::GetASCIIOrigin(referrer, origin);
> +      }
> +    } else if (sSendOriginHeader != 0) {
> +      nsContentUtils::GetASCIIOrigin(referrer, origin);
> +    }

We are removing the relation between referrer policy and origin header and I am pretty sure it will break mochitest and wpt test
Revision 1 by
on 
Review of attachment 9117176 [details] [diff] [review]:
-----------------------------------------------------------------

Just a quick look and this breaks the rule that origin header should follow Referrer Policy (in no-referrer and same-origin).
For example, if referrer policy is no-referrer and origin should be null

::: netwerk/protocol/http/nsHttpChannel.cpp
@@ +9838,5 @@
> +        nsContentUtils::GetASCIIOrigin(referrer, origin);
> +      }
> +    } else if (sSendOriginHeader != 0) {
> +      nsContentUtils::GetASCIIOrigin(referrer, origin);
> +    }

We are removing the relation between referrer policy and origin header and I am pretty sure it will break mochitest and wpt test
Revision 2 by
on 
Review of attachment 9117176 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch. Just a quick look and this breaks the rule that origin header should follow Referrer Policy (in no-referrer and same-origin).
For example, if referrer policy is no-referrer and origin should be null

::: netwerk/protocol/http/nsHttpChannel.cpp
@@ +9838,5 @@
> +        nsContentUtils::GetASCIIOrigin(referrer, origin);
> +      }
> +    } else if (sSendOriginHeader != 0) {
> +      nsContentUtils::GetASCIIOrigin(referrer, origin);
> +    }

We are removing the relation between referrer policy and origin header and I am pretty sure it will break mochitest and wpt test

Back to Bug 1605305 Comment 4