### Security Approval Request * **How easily could an exploit be constructed based on the patch?**: The crash is so far from this code that it's very hard to figure this out. We already narrowed this down by adding some code specifically to the css loader with the diagnostic patches, those were also approved. * **Do comments in the patch, the check-in comment, or tests included in the patch paint a bulls-eye on the security problem?**: No * **Which older supported branches are affected by this flaw?**: all * **If not all supported branches, which bug introduced the flaw?**: None * **Do you have backports for the affected branches?**: Yes * **If not, how different, hard to create, and risky will they be?**: easy to have them * **How likely is this patch to cause regressions; how much testing does it need?**: I will push to try (anonymously) and report back. This is a small change, but could have unforeseen consequences.
Bug 1605895 Comment 61 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
This patch is an attempt to actually fix this bug, no longer just a diagnostic assertion with data. It's based only on a theory but needs field testing, hence asking for landing this. ### Security Approval Request * **How easily could an exploit be constructed based on the patch?**: The crash is so far from this code that it's very hard to figure this out. We already narrowed this down by adding some code specifically to the css loader with the diagnostic patches, those were also approved. * **Do comments in the patch, the check-in comment, or tests included in the patch paint a bulls-eye on the security problem?**: No * **Which older supported branches are affected by this flaw?**: all * **If not all supported branches, which bug introduced the flaw?**: None * **Do you have backports for the affected branches?**: Yes * **If not, how different, hard to create, and risky will they be?**: easy to have them * **How likely is this patch to cause regressions; how much testing does it need?**: I will push to try (anonymously) and report back. This is a small change, but could have unforeseen consequences.