Bug 1608235 Comment 3 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
Crash happened at EGL_StreamConsumerGLTextureExternalAttribsNV(). It uses  "gl::Context *context    = gl::GetValidGlobalContext()" for validation check. The context  seemed to be nullptr.

ANGLE has similar checks in the followings.
- EGL_StreamConsumerGLTextureExternalKHR()
- EGL_StreamConsumerAcquireKHR()
- EGL_StreamConsumerReleaseKHR()
- EGL_StreamConsumerGLTextureExternalAttribsNV()

They affects only to 
- RenderDXGITextureHostOGL::EnsureLockable()
- RenderDXGIYCbCrTextureHostOGL::EnsureLockable()
Revision 1 by
on 
Crash happened at EGL_StreamConsumerGLTextureExternalAttribsNV(). It uses  "gl::Context *context    = gl::GetValidGlobalContext()" for validation check. The context  seemed to be nullptr.

ANGLE has similar checks in the followings.
- EGL_StreamConsumerGLTextureExternalKHR()
- EGL_StreamConsumerAcquireKHR()
- EGL_StreamConsumerReleaseKHR()
- EGL_StreamConsumerGLTextureExternalAttribsNV()

They affects only to 
- RenderDXGITextureHostOGL::EnsureLockable()
- RenderDXGIYCbCrTextureHostOGL::EnsureLockable()

When ANGLE detects a context lost, GetValidGlobalContext() returns nullptr.
https://searchfox.org/mozilla-central/rev/c52d5f8025b5c9b2b4487159419ac9012762c40c/gfx/angle/checkout/src/libANGLE/Thread.cpp#99

Back to Bug 1608235 Comment 3