Bug 1608837 Comment 1 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Edwin and I had a chat about this bug, here's a summary of the meeting..

Relevant parts of the code:

1. The [split chunks](https://searchfox.org/mozilla-central/source/taskcluster/taskgraph/transforms/tests.py#1301) transform
2. The [chunking.py](https://searchfox.org/mozilla-central/source/taskcluster/taskgraph/util/chunking.py) utility file
3. The [TestResolver](https://searchfox.org/mozilla-central/source/testing/mozbase/moztest/moztest/resolve.py#464)

Potential problems with WPT:

1. WPT does not have manifests, can maybe use [top-level dirs](https://searchfox.org/mozilla-central/source/testing/web-platform/tests) as stand-ins. Could either handle this in the `TestResolver` by setting the `manifest_relpath` to these values there, or by using an if statement somewhere in `chunking.py`.

2. WPT does not have runtime data in `testing/runtimes`. We'll either need to add WPT to these data files (by modifying the `writeruntimes` script) or use a different chunking algorithm.

3. WPT does not load test objects at the same time as others. May just need to call [this](https://searchfox.org/mozilla-central/source/testing/mozbase/moztest/moztest/resolve.py#642) function manually. Though, it might also *just work*. I'm not sure.


How to test:

1. `./mach taskgraph full` (see https://ahal.ca/casts/2018/taskgraph-like-a-pro/). Remember to log to stderr or taskgraph will get messed up.
2. Pushing to try and inspecting task (look for MOZHARNESS_TEST_PATHS in the env)
3. Should verify we aren't missing tests (I have a script for this but we can cross that bridge later)
Edwin and I had a chat about this bug, here's a summary of the meeting..

Relevant parts of the code:

1. The [split chunks](https://searchfox.org/mozilla-central/source/taskcluster/taskgraph/transforms/tests.py#1301) transform
2. The [chunking.py](https://searchfox.org/mozilla-central/source/taskcluster/taskgraph/util/chunking.py) utility file
3. The [TestResolver](https://searchfox.org/mozilla-central/source/testing/mozbase/moztest/moztest/resolve.py#464)

Potential problems with WPT:

1. WPT does not have manifests, can maybe use [top-level dirs](https://searchfox.org/mozilla-central/source/testing/web-platform/tests) as stand-ins. Could either handle this in the `TestResolver` by setting the `manifest_relpath` to these values there, or by using an if statement somewhere in `chunking.py`.

2. WPT does not have runtime data in `testing/runtimes`. We'll either need to add WPT to these data files (by modifying the `writeruntimes` script) or use a different chunking algorithm.

3. WPT does not load test objects at the same time as others. May just need to call [this](https://searchfox.org/mozilla-central/source/testing/mozbase/moztest/moztest/resolve.py#642) function manually. Though, it might also *just work*. I'm not sure.


How to test:

1. `./mach taskgraph full` (see https://ahal.ca/casts/2018/taskgraph-like-a-pro/). Remember to log to stderr or taskgraph will get messed up. Look for the `test_manifests` attribute in the full task
2. Pushing to try and inspecting task (look for MOZHARNESS_TEST_PATHS in the env)
3. Should verify we aren't missing tests (I have a script for this but we can cross that bridge later)

Back to Bug 1608837 Comment 1