Bug 1610597 Comment 7 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Ryan VanderMeulen [:RyanVM] from comment #6)
> So I'm clear, are we intending to land this patch on m-c too or just Beta? Given that we're getting close to having 74 go to Beta, I'd prefer the former if possible.

I agree with RyanVM -- given how small the patch is (and how large the regressing patch was, which makes the not-risky-assessment from comment 4 a little debatable), I'd like to see this patch land in Nightly as well, and then we can revert it on Nightly as part of a better non-legacy-stack fix.

(In reply to Tim Nguyen :ntim from comment #5)
> When I set `display: block/flow-root/inline-block` on `.notificationbox-stack` (as opposed to the current `display: grid`) the height seems to be computed correctly, [...]
> Daniel, do you know if this is the expected behaviour ?

I'll take a look today or tomorrow and see if I can figure out what's going on.
(In reply to Ryan VanderMeulen [:RyanVM] from comment #6)
> So I'm clear, are we intending to land this patch on m-c too or just Beta? Given that we're getting close to having 74 go to Beta, I'd prefer the former if possible.

I agree with RyanVM -- given how small the patch is (and how large the regressing patch was, which makes the not-risky-assessment from comment 4 a little debatable), I'd be more comfortable having this patch land in Nightly as well, and then we can revert it on Nightly as part of a better non-legacy-stack fix.

(In reply to Tim Nguyen :ntim from comment #5)
> When I set `display: block/flow-root/inline-block` on `.notificationbox-stack` (as opposed to the current `display: grid`) the height seems to be computed correctly, [...]
> Daniel, do you know if this is the expected behaviour ?

I'll take a look today or tomorrow and see if I can figure out what's going on.

Back to Bug 1610597 Comment 7