Bug 1611957 Comment 10 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Hamish Willee from comment #9)
> FF101 docs work for this can be tracked in https://github.com/mdn/content/issues/15470
> 
> A question. The [spec](https://w3c.github.io/webrtc-extensions/#dom-rtcrtpencodingparameters-maxframerate) indicates that maxFramerate value of 0 should stop the video if set to zero by  `RTCRtpSender.setParameters()`, and doesn't say what happens for `RTCPeerConnection.addTransceiver()` if the rate is set to zero.
> It looks like you have allowed 0 to indicate "no limit".
> 1. Is that correct?

Nope!

> 2. Isn't that a spec violation?

Yep! Sadly, this is a limitation in libwebrtc upstream; it crashes if you set a framerate of 0. There's nothing we can do about this on our end at the moment; upstream will need to fix this, and then we'll need to update our import.
(In reply to Hamish Willee from comment #9)
> FF101 docs work for this can be tracked in https://github.com/mdn/content/issues/15470
> 
> A question. The [spec](https://w3c.github.io/webrtc-extensions/#dom-rtcrtpencodingparameters-maxframerate) indicates that maxFramerate value of 0 should stop the video if set to zero by  `RTCRtpSender.setParameters()`, and doesn't say what happens for `RTCPeerConnection.addTransceiver()` if the rate is set to zero.
> It looks like you have allowed 0 to indicate "no limit".
> 1. Is that correct?

Nope! (You are correct, the behavior is not, not sure which question you were asking)

> 2. Isn't that a spec violation?

Yep! Sadly, this is a limitation in libwebrtc upstream; it crashes if you set a framerate of 0. There's nothing we can do about this on our end at the moment; upstream will need to fix this, and then we'll need to update our import.

Back to Bug 1611957 Comment 10