Bug 1614400 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
Looking at the unit tests for showSpocs, it looks like it's not really testing all of it very well, mainly the chunks inside placementsForEach and cache usage, is barely tested. It looks like it's mostly testing to satisfy code coverage.

I suspect part of the problem is the showSpocs function itself is simply doing too much.

If we broke that down into smaller functions, it would be easier to see where we need tests, and easier to make those tests.
Revision 1 by
on 
Looking at the unit tests for loadSpocs, it looks like it's not really testing all of it very well, mainly the chunks inside placementsForEach and cache usage, is barely tested. It looks like it's mostly testing to satisfy code coverage.

I suspect part of the problem is the loadSpocs function itself is simply doing too much.

If we broke that down into smaller functions, it would be easier to see where we need tests, and easier to make those tests.

Back to Bug 1614400 Comment 0