Bug 1615109 Comment 5 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

This is a problem with the way share picker registration is done. @mozilla.org/sharepicker;1 is associated with kNS_SHAREPICKER_CID, but then there is no implementation given for kNS_SHAREPICKER_CID. However, we don't use the sharepicked in the content process, so just remove that.

The stub implementation in browser/components/webshare/ also looks questionable to me:
* The share picker is defined on Android and Windows, so does that mean we have two implementations of webshare on those platforms? I'm not sure what happens there.
* The getters that return constant values should probably be fields. For instance, QueryInterface() will generate a new QI function every time it is called. (kmag pointed this out.)

I think the easiest fix for those two issues is to delete the stub implementation. ShareDelegate looks like a better implementation to crib off of at this point. I think the code will deal with @mozilla.org/sharepicker;1 not being implemented in a reasonable way, but I'll need to double check that.
This is a problem with the way share picker registration is done. @mozilla.org/sharepicker;1 is associated with kNS_SHAREPICKER_CID, but then there is no implementation given for kNS_SHAREPICKER_CID. However, we don't use the sharepicker in the content process, so just remove that.

The stub implementation in browser/components/webshare/ also looks questionable to me:
* The share picker is defined on Android and Windows, so does that mean we have two implementations of webshare on those platforms? I'm not sure what happens there.
* The getters that return constant values should probably be fields. For instance, QueryInterface() will generate a new QI function every time it is called. (kmag pointed this out.)

I think the easiest fix for those two issues is to delete the stub implementation. ShareDelegate looks like a better implementation to crib off of at this point. I think the code will deal with @mozilla.org/sharepicker;1 not being implemented in a reasonable way, but I'll need to double check that.

Back to Bug 1615109 Comment 5