[Tracking Requested - why for this release]: If you hide top sites on new tab (set `browser.newtabpage.activity-stream.feeds.topsites` to false) and restart Firefox, focusing the urlbar doesn't show the top sites anymore. That's because `this.activityStream.store.getState().TopSites.rows` is an empty array here: https://searchfox.org/mozilla-central/rev/c1e3d3edd4a9b784971555dc74a5de23d768b2e1/browser/modules/AboutNewTab.jsm#115 Which makes total since because top sites are disabled. Ed, how might we fix this? We need to show the top sites in the urlbar view even when they're hidden on new tab. Setting the pref to true, calling `AboutNewTab.getTopSites`, and then resetting it to false actually works, but it's hacky, and it also causes the top sites to flicker on and off if the current tab is new tab. Requesting tracking because we want to enable top sites in the urlbar on release on 74.
Bug 1617345 Comment 0 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
[Tracking Requested - why for this release]: If you hide top sites on new tab (set `browser.newtabpage.activity-stream.feeds.topsites` to false) and restart Firefox, focusing the urlbar doesn't show the top sites anymore. That's because `this.activityStream.store.getState().TopSites.rows` is an empty array here: https://searchfox.org/mozilla-central/rev/c1e3d3edd4a9b784971555dc74a5de23d768b2e1/browser/modules/AboutNewTab.jsm#115 Which makes total sense because top sites are disabled. Ed, how might we fix this? We need to show the top sites in the urlbar view even when they're hidden on new tab. Setting the pref to true, calling `AboutNewTab.getTopSites`, and then resetting it to false actually works, but it's hacky, and it also causes the top sites to flicker on and off if the current tab is new tab. Requesting tracking because we want to enable top sites in the urlbar on release on 74.