Currently devtools and newtab configure eslint to use `"parser": "babel-eslint"` and these directories can use newer js features like static class members and nullish operator. The babel-eslint@10.0.3 is already included at the top level package.json, so maybe we can configure eslint to use babel-eslint for all of m-c so developers can use newer features? Looks like it's not entirely trivial of just setting the parser as it seems to result in: ``` 5:5 error 'EXPORTED_SYMBOLS' is assigned a value but never used. no-unused-vars (eslint) ``` And there might be performance differences. Alternatively, newtab directory currently parses fine without babel-eslint, so that could be removed. (Looks like newtab unnecessarily specifies version 2018 and ecmaFeatures jsx isn't necessary anymore either??)
Bug 1617959 Comment 0 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
Currently devtools and newtab configure eslint to use `"parser": "babel-eslint"` and these directories can use newer js features like static class members, nullish operator (`??`), optional chaining (`?.`). The babel-eslint@10.0.3 is already included at the top level package.json, so maybe we can configure eslint to use babel-eslint for all of m-c so developers can use newer features? Looks like it's not entirely trivial of just setting the parser as it seems to result in: ``` 5:5 error 'EXPORTED_SYMBOLS' is assigned a value but never used. no-unused-vars (eslint) ``` And there might be performance differences. Alternatively, newtab directory currently parses fine without babel-eslint, so that could be removed. (Looks like newtab unnecessarily specifies version 2018 and ecmaFeatures jsx isn't necessary anymore either??)
Currently devtools and newtab configure eslint to use `"parser": "babel-eslint"` and these directories can use newer js features, e.g., static class members, nullish operator (`??`), optional chaining (`?.`). The babel-eslint@10.0.3 is already included at the top level package.json, so maybe we can configure eslint to use babel-eslint for all of m-c so developers can use newer features? Looks like it's not entirely trivial of just setting the parser as it seems to result in: ``` 5:5 error 'EXPORTED_SYMBOLS' is assigned a value but never used. no-unused-vars (eslint) ``` And there might be performance differences. Alternatively, newtab directory currently parses fine without babel-eslint, so that could be removed. (Looks like newtab unnecessarily specifies version 2018 and ecmaFeatures jsx isn't necessary anymore either??)