Bug 1619090 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Bug 1613337 added a ChromeWindowsLoginCrypto.jsm similar to ChromeMacOSLoginCrypto.jsm instead of directly importing OSCrypto.jsm directly from ChromeProfileMigrator.jsm.

MattN suggested as part of https://phabricator.services.mozilla.com/D64713 refactoring that it might be reasonable to get rid of OSCrypto as it's not quite how things were expected of it.

Before the change, OSCrypto.jsm was actually only referenced from windows, but all_files_referenced let it pass as it was a false negative. But with the change, an entry was added to all_files_referenced whitelist for now.
Bug 1613337 added a ChromeWindowsLoginCrypto.jsm similar to ChromeMacOSLoginCrypto.jsm instead of directly importing OSCrypto.jsm from ChromeProfileMigrator.jsm.

MattN suggested as part of https://phabricator.services.mozilla.com/D64713 refactoring that it might be reasonable to get rid of OSCrypto/_win as it's not quite how things were expected of it.

Before the change, OSCrypto.jsm was actually only referenced from windows, but all_files_referenced let it pass as it was a false negative. But with the change, an entry was added to all_files_referenced whitelist for now.

Back to Bug 1619090 Comment 0