Bug 1620101 Comment 8 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

I'll check out the autoland build, but I suspect `gdk_screen_get_root_window` will return the wrong `window` (I just checked in my gdb session open from yesterday and it returns `mGdkWindow->parent->parent` under Plasma, which doesn't have the property. Only the window "in-between" (as in `window->parent`) (whatever gdk means with "toplevel" I suppose, which is a different concept from "root" window) carries the property there.
I'll check out the autoland build, but I suspect `gdk_screen_get_root_window` will return the wrong `window` (I just checked in my gdb session open from yesterday and it returns `mGdkWindow->parent->parent` under Plasma, which doesn't have the property. Only the window "in-between" (as in `window->parent`) (whatever gdk means with "toplevel" I suppose, which is a different concept from "root" window apparently) carries the property there.
I'll check out the autoland build, but I suspect `gdk_screen_get_root_window` will return the wrong `window` (I just checked in my gdb session open from yesterday and it returns `mGdkWindow->parent->parent` under Plasma, which doesn't have the property. Only the window "in-between" (as in `mGdkWindow->parent`) (whatever gdk means with "toplevel" I suppose, which is a different concept from "root" window apparently) carries the property there.
I'll check out the autoland build, but I suspect `gdk_screen_get_root_window` will return the wrong `window` (I just checked in my gdb session open from yesterday and it returns `mGdkWindow->parent->parent` under Plasma, which doesn't have the property. Only the window "in-between" (as in `mGdkWindow->parent`) (whatever gdk means with "toplevel" I suppose, which is a different concept from "root" window apparently) carries the property there.

edit: the autoland build doesn't make it work :/
~~I'll check out the autoland build, but I suspect `gdk_screen_get_root_window` will return the wrong `window` (I just checked in my gdb session open from yesterday and it returns `mGdkWindow->parent->parent` under Plasma, which doesn't have the property. Only the window "in-between" (as in `mGdkWindow->parent`) (whatever gdk means with "toplevel" I suppose, which is a different concept from "root" window apparently) carries the property there.~~

edit: the autoland build doesn't make it work :/

edit2: forget what I wrote first, I think it's just the `GetWorkspaceID` that's still broken, because it operates on `mGdkWindow` instead of `gdk_window_get_(effective?)_toplevel(mGdkWindow)`.
~~I'll check out the autoland build, but I suspect `gdk_screen_get_root_window` will return the wrong `window` (I just checked in my gdb session open from yesterday and it returns `mGdkWindow->parent->parent` under Plasma, which doesn't have the property. Only the window "in-between" (as in `mGdkWindow->parent`) (whatever gdk means with "toplevel" I suppose, which is a different concept from "root" window apparently) carries the property there.~~

edit: the autoland build doesn't make it work :/

edit2: forget what I wrote first, I think it's just the `GetWorkspaceID` that's still broken, because it still operates on `mGdkWindow` instead of `gdk_window_get_(effective?)_toplevel(mGdkWindow)`.
~~I'll check out the autoland build, but I suspect `gdk_screen_get_root_window` will return the wrong `window` (I just checked in my gdb session open from yesterday and it returns `mGdkWindow->parent->parent` under Plasma, which doesn't have the property. Only the window "in-between" (as in `mGdkWindow->parent`) (whatever gdk means with "toplevel" I suppose, which is a different concept from "root" window apparently) carries the property there.~~

edit: the autoland build doesn't make it work :/

edit2: forget what I wrote first, I looked at the `GdkX11ScreenGetNumberOfDesktops`/`MoveToWorkspace` functions. I think it's just the `GetWorkspaceID` that's still broken, because it still operates on `mGdkWindow` instead of `gdk_window_get_(effective?)_toplevel(mGdkWindow)`.
~~I'll check out the autoland build, but I suspect `gdk_screen_get_root_window` will return the wrong `window` (I just checked in my gdb session open from yesterday and it returns `mGdkWindow->parent->parent` under Plasma, which doesn't have the property. Only the window "in-between" (as in `mGdkWindow->parent`) (whatever gdk means with "toplevel" I suppose, which is a different concept from "root" window apparently) carries the property there.~~

edit: the autoland build doesn't make it work :/

edit2: Disregard what I wrote initially; I looked at the `GdkX11ScreenGetNumberOfDesktops`/`MoveToWorkspace` functions. I think it's just the `GetWorkspaceID` that's still broken, because it still operates on `mGdkWindow` instead of `gdk_window_get_(effective?)_toplevel(mGdkWindow)`.
~~I'll check out the autoland build, but I suspect `gdk_screen_get_root_window` will return the wrong `window` (I just checked in my gdb session open from yesterday and it returns `mGdkWindow->parent->parent` under Plasma, which doesn't have the property. Only the window "in-between" (as in `mGdkWindow->parent`) (whatever gdk means with "toplevel" I suppose, which is a different concept from "root" window apparently) carries the property there.~~

edit: the autoland build doesn't make it work :/

edit2: Disregard what I wrote initially; I looked at the `GdkX11ScreenGetNumberOfDesktops`/`MoveToWorkspace` functions. The `GetWorkspaceID` is still broken in KDE Plasma, because it operates on `mGdkWindow` instead of `gdk_window_get_(effective?)_toplevel(mGdkWindow)`.
~~I'll check out the autoland build, but I suspect `gdk_screen_get_root_window` will return the wrong `window` (I just checked in my gdb session open from yesterday and it returns `mGdkWindow->parent->parent` under Plasma, which doesn't have the property.~~ Only the window "in-between" (as in `mGdkWindow->parent`) (whatever gdk means with "toplevel" I suppose, which is a different concept from "root" window apparently) carries the property there.

edit: the autoland build doesn't make it work :/

edit2: Disregard what I wrote initially; I looked at the `GdkX11ScreenGetNumberOfDesktops`/`MoveToWorkspace` functions. The `GetWorkspaceID` is still broken in KDE Plasma, because it operates on `mGdkWindow` instead of `gdk_window_get_(effective?)_toplevel(mGdkWindow)`.
~~I'll check out the autoland build, but I suspect `gdk_screen_get_root_window` will return the wrong `window` (I just checked in my gdb session open from yesterday and it returns `mGdkWindow->parent->parent` under Plasma, which doesn't have the property.~~ Only the window "in-between" (as in `mGdkWindow->parent`) (whatever gdk means with "toplevel" I suppose, which is a different concept from "root" window apparently) carries the property there.

edit: the autoland build doesn't make it work :/

edit2: Disregard what I wrote initially; I looked at the `GdkX11ScreenGetNumberOfDesktops`/`MoveToWorkspace` functions. The `GetWorkspaceID` is still broken in KDE Plasma, because it operates on `mGdkWindow` instead of `gdk_window_get_(effective?)_toplevel(mGdkWindow)`.

edit3: `MoveToWorkspace` may also need to use the "toplevel" window instead of the "root" window, but I have a hard time debugging without symbols / sources loaded into gdb for Firefox (I haven't used the Mozilla symbol server in years and never loaded source code manually).
~~I'll check out the autoland build, but I suspect `gdk_screen_get_root_window` will return the wrong `window` (I just checked in my gdb session open from yesterday and it returns `mGdkWindow->parent->parent` under Plasma, which doesn't have the property.~~ Only the window "in-between" (as in `mGdkWindow->parent`) (whatever gdk means with "toplevel" I suppose, which is a different concept from "root" window apparently) carries the property there.

edit: the autoland build doesn't make it work :/

edit2: Disregard what I wrote initially; I looked at the `GdkX11ScreenGetNumberOfDesktops`/`MoveToWorkspace` functions. The `GetWorkspaceID` is still broken in KDE Plasma, because it operates on `mGdkWindow` instead of `gdk_window_get_(effective?)_toplevel(mGdkWindow)`.
~~I'll check out the autoland build, but I suspect `gdk_screen_get_root_window` will return the wrong `window` (I just checked in my gdb session open from yesterday and it returns `mGdkWindow->parent->parent` under Plasma, which doesn't have the property.~~ Only the window "in-between" (as in `mGdkWindow->parent`) (whatever gdk means with "toplevel" I suppose, which is a different concept from "root" window apparently) carries the property there.

edit: the autoland build doesn't make it work :/

edit2: Disregard my first sentence; I looked at the `GdkX11ScreenGetNumberOfDesktops`/`MoveToWorkspace` functions. The `GetWorkspaceID` is still broken in KDE Plasma, because it operates on `mGdkWindow` instead of `gdk_window_get_(effective?)_toplevel(mGdkWindow)`.

Back to Bug 1620101 Comment 8