Bug 1624402 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
Android Firefox builds define `CHECK_FORK_GETPID` for NSS.  After bug 1603628, NSS defines `NO_FORK_CHECK` by default.

This combination of defines yields a build failure, as [this](https://searchfox.org/mozilla-central/source/security/nss/lib/softoken/pkcs11.c#3327) access isn't guarded by `ifndef NO_FORK_CHECK`.

`/builds/worker/checkouts/gecko/security/nss/lib/softoken/pkcs11.c:3421:5: error: use of undeclared identifier 'myPid'`

We may be able to drop the define in Firefox builds, but NSS should still compile in this configuration.
Revision 1 by
on 
Android Firefox builds define `CHECK_FORK_GETPID` for NSS.  After bug 1603628, NSS defines `NO_FORK_CHECK` by default.

This combination of defines yields a build failure, as [this](https://searchfox.org/mozilla-central/source/security/nss/lib/softoken/pkcs11.c#3327) access isn't guarded by `ifndef NO_FORK_CHECK`. 

`/builds/worker/checkouts/gecko/security/nss/lib/softoken/pkcs11.c:3421:5: error: use of undeclared identifier 'myPid'` [here](https://treeherder.mozilla.org/#/jobs?repo=try&revision=42ae4bea0c26b5b1b0f73f3ccc32dfa1978333ed)

We may be able to drop the define in Firefox builds, but NSS should still compile in this configuration.

Back to Bug 1624402 Comment 0