Also move MOZ_MUST_USE before function declarations' specifiers and return type. While clang and gcc's `__attribute__((warn_unused_result))` can appear before, between, or after function specifiers and return types, the [[nodiscard]] attribute must precede the function specifiers.
Bug 1624789 Comment 0 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
The MOZ_MUST_USE macro is defined as clang's and gcc's nonstandard attribute((warn_unused_result)). Now that we compile as C++17 by default (bug 1560664), we can replace MOZ_MUST_USE with C++17's standard [[nodiscard]] attribute. Also move MOZ_MUST_USE before function declarations' specifiers and return type. While clang and gcc's `__attribute__((warn_unused_result))` can appear before, between, or after function specifiers and return types, the [[nodiscard]] attribute must precede the function specifiers.