Bug 1625263 Comment 10 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Alessandro Castellani (:aleca) from comment #0)
> Bug 1613284 highlighted an issue in which the attachment pane was lacking proper accessible keyboard shortcuts to trigger the file chooser if a file was already attached.

Unfortunately, that's an incorrect and misleading representation of bug 1613284 as filed by myself, and allegedly "fixed" by others.
For the avoidance of doubt, everyone (because original design is so seriously broken everywhere):

**Alt+M was *never* designed to trigger the attach file dialog. Whenever you see that, it's a *bug*, and I have never requested such behaviour!**

- Bug 1613284 was filed to **restore summoning and dismissing the attachment *bucket* via keyboard (Alt+M for en-US)**, as described in section "UX-design of Attachment Pane View State Machinery" of comment 6. Just that, summon and dismiss attachment pane.
- Patch of Bug 1613284, instead of restoring the carefully crafted and correctly working UX design, has **crippled the UX by removing Alt+M accesskey**, spelling doom for keyboard users as they lose intuitive access not just to attaching files, but many more actions per comment 6, section "List of functions ... via Alt+M".
- Wrt to the new duplicate [Attach Files] button inside AP, as Jörg said, we cannot use Alt+F access key for attaching files because that's taken by file menu. And attaching files already has a shortcut, Strg+Shift+A, and before Alt+M was removed as an access key, many other simple keyboard ways.

> A newly added button was introduced to fix the issue
Well, per above explanation I think there might have been some misunderstandings here.

> but now the section doesn't look great.
> Let's rethink that area and make it gorgeous and functional.

That's good, but is this the right time for another big task?
(In reply to Alessandro Castellani (:aleca) from comment #0)
> Bug 1613284 highlighted an issue in which the attachment pane was lacking proper accessible keyboard shortcuts to trigger the file chooser if a file was already attached.

Unfortunately, that's an incorrect and misleading representation of bug 1613284 as filed by myself, and allegedly "fixed" by others.
For the avoidance of doubt, everyone (because original design is so seriously broken everywhere):

**Alt+M was *never* designed to trigger the attach file dialog. Whenever you see that, it's a *bug*, and I have never requested such behaviour!**

- Bug 1613284 was filed to **restore summoning and dismissing the attachment *bucket* via keyboard (Alt+M for en-US)**, as described in section "UX-design of Attachment Pane View State Machinery" of comment 6. Just that, summon and dismiss attachment pane via keyboard, for keyboard access.
- Patch of Bug 1613284, instead of restoring the carefully crafted and correctly working UX design, has **crippled the UX by removing Alt+M accesskey**, spelling doom for keyboard users as they lose intuitive access not just to attaching files, but many more actions per comment 6, section "List of functions ... via Alt+M".
- Wrt to the new duplicate [Attach Files] button inside AP, as Jörg said, we cannot use Alt+F access key for attaching files because that's taken by file menu. And attaching files already has a shortcut, Strg+Shift+A, and before Alt+M was removed as an access key, many other simple keyboard ways.

> A newly added button was introduced to fix the issue
Well, per above explanation I think there might have been some misunderstandings here.

> but now the section doesn't look great.
> Let's rethink that area and make it gorgeous and functional.

That's good, but is this the right time for another big task?
(In reply to Alessandro Castellani (:aleca) from comment #0)
> Bug 1613284 highlighted an issue in which the attachment pane was lacking proper accessible keyboard shortcuts to trigger the file chooser if a file was already attached.

Unfortunately, that's an incorrect and misleading representation of bug 1613284 as filed by myself, and allegedly "fixed" by others.
For the avoidance of doubt, everyone (because original design is so seriously broken everywhere):

**Alt+M was *never* designed to trigger the attach file dialog. Whenever you see that, it's a *bug*, and I have never requested such behaviour!**

- Bug 1613284 was filed to **restore summoning and dismissing the attachment *bucket* via keyboard (Alt+M for en-US)**, as described in section "UX-design of Attachment Pane View State Machinery" of comment 6. Just that, summon and dismiss attachment pane via keyboard.
- Patch of Bug 1613284, instead of restoring the carefully crafted and correctly working UX design, has **crippled the UX by removing Alt+M accesskey**, spelling doom for keyboard users as they lose intuitive access not just to attaching files, but many more actions per comment 6, section "List of functions ... via Alt+M".
- Wrt to the new duplicate [Attach Files] button inside AP, as Jörg said, we cannot use Alt+F access key for attaching files because that's taken by file menu. And attaching files already has a shortcut, Strg+Shift+A, and before Alt+M was removed as an access key, many other simple keyboard ways.

> A newly added button was introduced to fix the issue
Well, per above explanation I think there might have been some misunderstandings here.

> but now the section doesn't look great.
> Let's rethink that area and make it gorgeous and functional.

That's good, but is this the right time for another big task?
(In reply to Alessandro Castellani (:aleca) from comment #0)
> Bug 1613284 highlighted an issue in which the attachment pane was lacking proper accessible keyboard shortcuts to trigger the file chooser if a file was already attached.

Unfortunately, that's an incorrect and misleading representation of bug 1613284 as filed by myself, and allegedly "fixed" by others.
For the avoidance of doubt, everyone (because original design is so seriously broken everywhere):

**Alt+M was *never* designed to trigger the attach file dialog. Whenever you see that, it's a *bug*, and I have never requested such behaviour!**

- Bug 1613284 was filed to **restore summoning and dismissing the attachment *bucket* via keyboard (Alt+M for en-US)**, as described in section "UX-design of Attachment Pane View State Machinery" of comment 6. Just that, summon and dismiss attachment pane via keyboard. For a shown but unfocused attachment pane, *summoning* translates to *focus* (hence *access key*, now lost).
- Patch of Bug 1613284, instead of restoring the carefully crafted and correctly working UX design, has **crippled the UX by removing Alt+M accesskey**, spelling doom for keyboard users as they lose intuitive access not just to attaching files, but many more actions per comment 6, section "List of functions ... via Alt+M".
- Wrt to the new duplicate [Attach Files] button inside AP, as Jörg said, we cannot use Alt+F access key for attaching files because that's taken by file menu. And attaching files already has a shortcut, Strg+Shift+A, and before Alt+M was removed as an access key, many other simple keyboard ways.

> A newly added button was introduced to fix the issue
Well, per above explanation I think there might have been some misunderstandings here.

> but now the section doesn't look great.
> Let's rethink that area and make it gorgeous and functional.

That's good, but is this the right time for another big task?

Back to Bug 1625263 Comment 10