Bug 1625263 Comment 31 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Thomas D. from comment #30)
> Created attachment 9146850 [details] [diff] [review]
> This patch fixes and polishes keyboard access to the full functionality of attachment pane (as discussed).

Please note pre-existing access bugs:
- With full bucket shown, no keyboard access to the attachment pane whitespace context menu. Expected (inbuilt for richlistbox!): after deselecting all items, context menu key or Shift+F10 must open the whitespace context (cf. Win Explorer). We open the item context menu instead. Users can still use Ctrl+Shift+A to attach files on Windows (see below). Pane context menu works perfectly for empty bucket (context menu key / Shift+F10 from focused, empty bucket).
- Someone said that Ctrl+Shift+A keyboard shortcut for "Attach File(s)..." is broken for MAC and Linux. Works perfectly on our biggest platform, Windows. (On a focused, empty bucket, you can also attach via pane context menu per above, or just press Enter to attach.)

We need to fix those on their own bugs (haven't checked for them), as well as bug 1634946.
(In reply to Thomas D. from comment #30)
> Created attachment 9146850 [details] [diff] [review]
> This patch fixes and polishes keyboard access to the full functionality of attachment pane (as discussed).

Please note pre-existing access bugs:
- With full bucket shown, no keyboard access to the attachment pane whitespace context menu. Expected (inbuilt for richlistbox!): after deselecting all items, context menu key or Shift+F10 must open the *whitespace* context menu (cf. Win Explorer), not the *item* context menu. Users can still use Ctrl+Shift+A to attach files on Windows (see below). Pane context menu works perfectly for empty bucket (context menu key / Shift+F10 from focused, empty bucket).
- Someone said that Ctrl+Shift+A keyboard shortcut for "Attach File(s)..." is broken for MAC and Linux. Works perfectly on our biggest platform, Windows. (On a focused, empty bucket, you can also attach via pane context menu per above, or just press Enter to attach.)

We need to fix those on their own bugs (haven't checked for them), as well as bug 1634946.

Back to Bug 1625263 Comment 31