Bug 1625786 Comment 14 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to tustamido from comment #13)
> Maybe some of you missed my comment #3. This bug here is not a regression, at least not from bug 1597475.

Ah, indeed I had missed that, thanks.

> Unintentionally, my STR led to Clara Guerrero (comment #1) to discover another similar bug. This other one that seems to be regressed by bug 1597475.

That makes no sense. I re-run mozregression with the STR from comment 1 and I got something that looks much more plausible:

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=398b5e6b2dab72d5be60bc81b0fda2d2c27bfb25&
tochange=b9740bd7bf8f1a0656c09a88fe6d7ee00586ee60

It seems bug 1626573 is kinda similar and is already on file. Baku, Subhamoy, is the "open a new tab, paste blob URI" case also handled here? To be clear, the STR are "Copy Image Location" from an image in whatsapp (from a blob URI), and paste it in urlbar. I suspect it might be different because the navigation is triggered by typing out the uri, so let me know if you want a separate bug on file for that.

> This bug here: whatsappSticker.src != whatsappSticker.currentSrc. The correct value is src, the value in currentSrc is invalid (this is the bug). "Copy Image Location" gets the currentSrc, then if you paste it in urlbar, an error will appear. But if you inspect the element, manually copy the src of the img element and try to load this url, then the image will be displayed correctly.

Alright, with that situation clarified, I'll dig into this.

> Sorry if I'm not being clear enough, english is not my native language.

Np! (neither mine :)). Thank you so much :)
(In reply to tustamido from comment #13)
> Maybe some of you missed my comment #3. This bug here is not a regression, at least not from bug 1597475.

Ah, indeed I had missed that, thanks.

> Unintentionally, my STR led to Clara Guerrero (comment #1) to discover another similar bug. This other one that seems to be regressed by bug 1597475.

That makes no sense. I re-run mozregression with the STR from comment 1 and I got something that looks much more plausible:

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=398b5e6b2dab72d5be60bc81b0fda2d2c27bfb25&tochange=b9740bd7bf8f1a0656c09a88fe6d7ee00586ee60

It seems bug 1626573 is kinda similar and is already on file. Baku, Subhamoy, is the "open a new tab, paste blob URI" case also handled here? To be clear, the STR are "Copy Image Location" from an image in whatsapp (from a blob URI), and paste it in urlbar. I suspect it might be different because the navigation is triggered by typing out the uri, so let me know if you want a separate bug on file for that.

> This bug here: whatsappSticker.src != whatsappSticker.currentSrc. The correct value is src, the value in currentSrc is invalid (this is the bug). "Copy Image Location" gets the currentSrc, then if you paste it in urlbar, an error will appear. But if you inspect the element, manually copy the src of the img element and try to load this url, then the image will be displayed correctly.

Alright, with that situation clarified, I'll dig into this.

> Sorry if I'm not being clear enough, english is not my native language.

Np! (neither mine :)). Thank you so much :)

Back to Bug 1625786 Comment 14