I should note that there are a few error-cases in openh264's OpenH264VideoDecoder::Decode_m that are not propagated back to the GMP parent. Hitting any one of these could result in the reported deadlock: https://github.com/cisco/openh264/blob/6fe15a6b82d492bebe388c55b7ee5131208e7334/module/gmp-openh264.cpp#L888 https://github.com/cisco/openh264/blob/6fe15a6b82d492bebe388c55b7ee5131208e7334/module/gmp-openh264.cpp#L895 https://github.com/cisco/openh264/blob/6fe15a6b82d492bebe388c55b7ee5131208e7334/module/gmp-openh264.cpp#L908
Bug 1626364 Comment 1 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
I should note that there are a few error-cases in openh264's OpenH264VideoDecoder::Decode_m that are not propagated back to the GMP parent. Hitting any one of these could result in the reported deadlock: https://github.com/cisco/openh264/blob/6fe15a6b82d492bebe388c55b7ee5131208e7334/module/gmp-openh264.cpp#L888 https://github.com/cisco/openh264/blob/6fe15a6b82d492bebe388c55b7ee5131208e7334/module/gmp-openh264.cpp#L895 https://github.com/cisco/openh264/blob/6fe15a6b82d492bebe388c55b7ee5131208e7334/module/gmp-openh264.cpp#L908 I would expect all of these to do something like this: https://github.com/cisco/openh264/blob/6fe15a6b82d492bebe388c55b7ee5131208e7334/module/gmp-openh264.cpp#L861
I should note that there are a few error-cases in openh264's OpenH264VideoDecoder::Decode_m that are not propagated back to the GMP parent. Hitting any one of these could result in the reported deadlock: https://github.com/cisco/openh264/blob/6fe15a6b82d492bebe388c55b7ee5131208e7334/module/gmp-openh264.cpp#L888 https://github.com/cisco/openh264/blob/6fe15a6b82d492bebe388c55b7ee5131208e7334/module/gmp-openh264.cpp#L895 https://github.com/cisco/openh264/blob/6fe15a6b82d492bebe388c55b7ee5131208e7334/module/gmp-openh264.cpp#L908 All of these should probably be doing error handling something like this: https://github.com/cisco/openh264/blob/6fe15a6b82d492bebe388c55b7ee5131208e7334/module/gmp-openh264.cpp#L861