That doesn't encompass not having (pinned) topsites at all in the urlbar, the pref itself being inconsistent, and the UX issues of the about:preferences checkbox introduced in this bug. I don't see how a check box "Top sites" under the sentence "When using the address bar, suggest" conveys the information: "Unchecking this will remove topsites from the suggestions **and** prevent suggestions from appearing at all on focus".
Bug 1627858 Comment 80 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
That doesn't encompass not having (pinned) topsites at all in the urlbar, the pref itself being inconsistent, and the UX issues of the about:preferences checkbox introduced in this bug. I don't see how a check box "Top sites" under the sentence "When using the address bar, suggest" conveys the information: "Unchecking this will remove topsites from the suggestions **and** prevent suggestions from appearing at all on focus". I can guarantee you that if this hits release in this state, there's gonna be another outcry of users confused that this new option does not actually do what it says it does.
That doesn't encompass not having (pinned) topsites at all in the urlbar, the pref itself being inconsistent, and the UX issues of the about:preferences checkbox introduced in this bug. I don't see how a check box "Top sites" under the sentence "When using the address bar, suggest" conveys the information: "Unchecking this will remove topsites from the suggestions **and** prevent suggestions from appearing at all on focus". I can guarantee you that if this hits release in this state, there's gonna be another outcry of users that are at best, confused that this new option does not actually do what it says it does, and at worst, will accuse Mozilla of being actively misleading.