Bug 1630176 Comment 8 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

This is the full log for the failure from comment #7:

```
INFO - TEST-START | dom/serviceworkers/test/test_notification_openWindow.html
...
INFO - Registering service worker.
INFO - Setting browser.link.open_newwindow to 1.
INFO - Showing notification.
INFO - Waiting for "DONE" from worker.
INFO - TEST-FAIL | dom/serviceworkers/test/test_notification_openWindow.html | The author of the test has indicated that flaky timeouts are expected.  Reason: Mock alert service dispatches show and click events. 
INFO - TEST-FAIL | dom/serviceworkers/test/test_notification_openWindow.html | The author of the test has indicated that flaky timeouts are expected.  Reason: Mock alert service dispatches show and click events. 
INFO - TEST-PASS | dom/serviceworkers/test/test_notification_openWindow.html | Didn't crash! 
INFO - Setting browser.link.open_newwindow to 2.
INFO - Showing notification.
INFO - Waiting for "DONE" from worker.
INFO - TEST-FAIL | dom/serviceworkers/test/test_notification_openWindow.html | The author of the test has indicated that flaky timeouts are expected.  Reason: Mock alert service dispatches show and click events. 
INFO - TEST-FAIL | dom/serviceworkers/test/test_notification_openWindow.html | The author of the test has indicated that flaky timeouts are expected.  Reason: Mock alert service dispatches show and click events. 
INFO - TEST-UNEXPECTED-FAIL | dom/serviceworkers/test/test_notification_openWindow.html | Test timed out. 
```

So we're timing out waiting for the "DONE" message, which could mean a few different things: 1) we're not clicking the notification, so we're not even running the code that starts the test [here](https://searchfox.org/mozilla-central/rev/25d491b7924493b5d4bedc07841a1cd92f271100/dom/serviceworkers/test/notification_openWindow_worker.js#23-25) (this is the expected timeout, and we can ignore it), or 2) we're just not seeing the "DONE" message from the test file, which is sent [here](https://searchfox.org/mozilla-central/rev/25d491b7924493b5d4bedc07841a1cd92f271100/dom/serviceworkers/test/file_notification_openWindow.html#16-17).

It's very unlikely that we're in the second case, so I think it's fine to ignore this, but this started re-appearing on May 27 (right after bug 1630323 landed), so redirecting to annyG in case I'm missing something. We can probably add some more logs to confirm which case we're in.
This is the full log for the failure from comment #7:

```
INFO - TEST-START | dom/serviceworkers/test/test_notification_openWindow.html
...
INFO - Registering service worker.
INFO - Setting browser.link.open_newwindow to 1.
INFO - Showing notification.
INFO - Waiting for "DONE" from worker.
INFO - TEST-FAIL | dom/serviceworkers/test/test_notification_openWindow.html | The author of the test has indicated that flaky timeouts are expected.  Reason: Mock alert service dispatches show and click events. 
INFO - TEST-FAIL | dom/serviceworkers/test/test_notification_openWindow.html | The author of the test has indicated that flaky timeouts are expected.  Reason: Mock alert service dispatches show and click events. 
INFO - TEST-PASS | dom/serviceworkers/test/test_notification_openWindow.html | Didn't crash! 
INFO - Setting browser.link.open_newwindow to 2.
INFO - Showing notification.
INFO - Waiting for "DONE" from worker.
INFO - TEST-FAIL | dom/serviceworkers/test/test_notification_openWindow.html | The author of the test has indicated that flaky timeouts are expected.  Reason: Mock alert service dispatches show and click events. 
INFO - TEST-FAIL | dom/serviceworkers/test/test_notification_openWindow.html | The author of the test has indicated that flaky timeouts are expected.  Reason: Mock alert service dispatches show and click events. 
INFO - TEST-UNEXPECTED-FAIL | dom/serviceworkers/test/test_notification_openWindow.html | Test timed out. 
```

So we're timing out waiting for the "DONE" message, which could mean a few different things: 1) we're not clicking the notification, so we're not even running the code that starts the test [here](https://searchfox.org/mozilla-central/rev/25d491b7924493b5d4bedc07841a1cd92f271100/dom/serviceworkers/test/notification_openWindow_worker.js#23-25) (this is the case that is expected to timeout, so we can ignore it), or 2) we're just not seeing the "DONE" message from the test file, which is sent [here](https://searchfox.org/mozilla-central/rev/25d491b7924493b5d4bedc07841a1cd92f271100/dom/serviceworkers/test/file_notification_openWindow.html#16-17).

It's very unlikely that we're in the second case, so I think it's fine to ignore this, but this started re-appearing on May 27 (right after bug 1630323 landed), so redirecting to annyG in case I'm missing something. We can probably add some more logs to confirm which case we're in.

Back to Bug 1630176 Comment 8