Bug 1630943 Comment 16 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
2 of 2.  This fixes the problem by bringing `prepHttpChannel` into line with the recently refactored caldav code.  I've tested it manually with the test calendars Kai provided, and the caldav xpcshell tests pass locally.  

Try run, just started: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=236daf552cbe3f4e2931f5129712b571f658b7e8

Aside: XPCOM remains more mysterious to me than I'd like.  Here the difference between these two ways of getting a calICalendar from the aNotificationsCallbacks argument is something I'd like to understand better.  Will have to look into it further.
Revision 1 by
on 
2 of 2.  This fixes the problem by bringing `prepHttpChannel` into line with the recently refactored caldav code.  I've tested it manually with the test calendars Kai provided, and the caldav xpcshell tests pass locally.  

Try run, just started: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=236daf552cbe3f4e2931f5129712b571f658b7e8

Aside: XPCOM remains more mysterious to me than I'd like.  Here the difference between these two ways of getting a calICalendar from the aNotificationsCallbacks argument is something I'd like to understand better.  Will have to look into it further.

Edit: Here's the difference: https://searchfox.org/mozilla-central/source/xpcom/base/nsIInterfaceRequestor.idl#10-18

Back to Bug 1630943 Comment 16