In the first version of WebVR we shared the surface textues between the compositor and the VR surface. When we enter VR presentation we stop the Compostor, so we added that call to avoid a atachment ownership between the compositor and the VR render thread. SurfaceTextures can only be attached to one context at a time. The good news is that we switched to a separate SurfaceTexture set some time ago, so VR doesn't need that DetachAllFromGLContext anymore. It shoul be pretty safe to rever.t. Anyway I'll make some tests in VR to make sure we are not missing anything.
Bug 1633432 Comment 7 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
In the first version of WebVR we shared the surface textues between the compositor and the VR surface. When we enter VR presentation we stop the Compositor, so we added that call to avoid a atachment ownership between the compositor and the VR render thread. SurfaceTextures can only be attached to one context at a time. The good news is that we switched to a separate SurfaceTexture set some time ago, so VR doesn't need that DetachAllFromGLContext anymore. It shoul be pretty safe to rever.t. Anyway I'll make some tests in VR to make sure we are not missing anything.
In the first version of WebVR we shared the surface textues between the compositor and the VR surface. When we enter VR presentation we stop the Compositor, so we added that call to avoid a atachment ownership between the compositor and the VR render thread. SurfaceTextures can only be attached to one context at a time. The good news is that we switched to a separate SurfaceTexture set some time ago, so VR doesn't need that DetachAllFromGLContext anymore. It should be pretty safe to rever.t. Anyway I'll make some tests in VR to make sure we are not missing anything.