Bug 1633568 Comment 1 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

Original comment by
on 
Marissa, couple of questions:

In the proposal you also list a `seq` (running ping counter) - but this ping is supposed to fire only once. Is that field still useful then?

Why is the `created` field a local timestamp? Should that not be a full datetime that includes the offset from UTC? Isn't that what we do in other pings? Just making sure we pick the right format here.

This ping will fire once as soon at the Adjust attribution callback is done. If that callback does not happen then this ping will not be sent. If the attribution callback happens in a later session, this ping will go out then. Does that match your expectations?
Revision 1 by
on 
Marissa, couple of questions:

In the proposal you also list a `seq` (running ping counter) - but this ping is supposed to fire only once. Is that field still useful then?

This ping will fire once as soon at the Adjust attribution callback is done. If that callback does not happen then this ping will not be sent. If the attribution callback happens in a later session, this ping will go out then. Does that match your expectations?

The ActivationPing also has `app_name` and `channel` - do we need those too?
Revision 2 by
on 
Marissa, couple of questions:

In the proposal you also list a `seq` (running ping counter) - but this ping is supposed to fire only once. Is that field still useful then?

This ping will fire once as soon as the Adjust attribution callback is done. If that callback does not happen then this ping will not be sent. If the attribution callback happens in a later session, this ping will go out then. Does that match your expectations?

The ActivationPing also has `app_name` and `channel` - do we need those too?
Revision 3 by
on 
Marissa, couple of questions:

In the proposal you also list a `seq` (running ping counter) - but this ping is supposed to fire only once. Is that field still useful then?

This ping will fire once as soon as the Adjust attribution callback is received. If that callback does not happen then this ping will not be sent. If the attribution callback happens in a later session, this ping will go out then. Does that match your expectations?

The ActivationPing also has `app_name` and `channel` - do we need those too?

Back to Bug 1633568 Comment 1