Bug 1634556 Comment 18 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

(In reply to Shane Caraveo (:mixedpuppy) from comment #17)
> Did this regress the browser and page action panels, or just the sidebar?  I commented on the review that the patch only works with the sidebar.

I'm sorry, I'm not familiar enough with the different panel types, embedding methods, to confirm that this works in all cases. As demonstrated in the test, this works for web extensions embedded in a sidebar. If there is a case that fails, please provide Steps to Reproduce and I will attempt to make the patch work correctly in that case as well.
(In reply to Shane Caraveo (:mixedpuppy) from comment #17)
> Did this regress the browser and page action panels, or just the sidebar?  I commented on the review that the patch only works with the sidebar.

I'm sorry, I'm not familiar enough with the different panel types, embedding methods, to confirm that this works in all cases. As demonstrated in the test, this works for web extensions embedded in a sidebar. If there is a case that fails, please provide Steps to Reproduce and I will attempt to make the patch work correctly in that case as well.

To be clear, mousewheel zooming already works correctly for browser panels and for web extensions hosted in their own tab, and with Bug 1655244, it will work in Thunderbird. I'm not sure what other cases need to be covered.

Back to Bug 1634556 Comment 18