Bug 1636036 Comment 0 Edit History

Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.

After rebasing our patch set to 77.0b1 GeckoView compilation suddenly breaks with:

```
50:00.21 In file included from /var/tmp/build/geckoview-4ac6652a6a29/mobile/android/components/geckoview/GeckoViewExternalAppService.cpp:10:
50:00.21 /var/tmp/build/geckoview-4ac6652a6a29/obj-arm-linux-androideabi/dist/include/mozilla/dom/WindowGlobalParent.h:14:10: fatal error: 'mozilla/dom/ClientIPCTypes.h' file not found
50:00.21 #include "mozilla/dom/ClientIPCTypes.h"
50:00.21          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
looking at the patches in bug 1620657 nothing immediately jumps to mind, though. Here is the mozconfig file that worked so far:

```
mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/obj-arm-linux-androideabi
mk_add_options MOZ_APP_DISPLAYNAME="Tor Browser"
export MOZILLA_OFFICIAL=1
CC="clang"
CXX="clang++"

ac_add_options --with-android-min-sdk=16

ac_add_options --enable-optimize
ac_add_options --enable-official-branding

ac_add_options --enable-application=mobile/android
ac_add_options --target=arm-linux-androideabi
ac_add_options --with-android-ndk=/var/tmp/dist/android-toolchain/android-ndk
ac_add_options --with-android-sdk=/var/tmp/dist/android-toolchain/android-sdk-linux
ac_add_options --with-gradle=/var/tmp/dist/android-toolchain/gradle/gradle-5.1.1/bin/gradle

# We do not use Tor Launcher on Android:
ac_add_options --disable-tor-launcher

if [ -z "${TB_BUILD_WITH_UPDATER}" ]; then
# Because Google Play will likely be the primary distribution medium,
# we disable updating and rely on Google Play by default. The
# Developer Policy explicitly prohibits in-app updating:
#    An app distributed via Google Play may not modify, replace, or
#    update itself using any method other than Google Plays update
#    mechanism.
# https://play.google.com/about/privacy-security-deception/malicious-behavior/

    ac_add_options --disable-tor-browser-update
    ac_add_options --disable-verify-mar
fi

ac_add_options --enable-strip
ac_add_options --disable-tests
ac_add_options --disable-debug
ac_add_options --disable-rust-debug
ac_add_options --disable-crashreporter
ac_add_options --disable-webrtc

ac_add_options --enable-proxy-bypass-protection

# Disable telemetry
ac_add_options MOZ_TELEMETRY_REPORTING=
```
After rebasing our patch set to 77.0b1 GeckoView compilation suddenly breaks with:

```
50:00.21 In file included from /var/tmp/build/geckoview-4ac6652a6a29/mobile/android/components/geckoview/GeckoViewExternalAppService.cpp:10:
50:00.21 /var/tmp/build/geckoview-4ac6652a6a29/obj-arm-linux-androideabi/dist/include/mozilla/dom/WindowGlobalParent.h:14:10: fatal error: 'mozilla/dom/ClientIPCTypes.h' file not found
50:00.21 #include "mozilla/dom/ClientIPCTypes.h"
50:00.21          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
Looking at the patches in bug 1620657 nothing immediately jumps to mind, though. Here is the mozconfig file that worked so far:

```
mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/obj-arm-linux-androideabi
mk_add_options MOZ_APP_DISPLAYNAME="Tor Browser"
export MOZILLA_OFFICIAL=1
CC="clang"
CXX="clang++"

ac_add_options --with-android-min-sdk=16

ac_add_options --enable-optimize
ac_add_options --enable-official-branding

ac_add_options --enable-application=mobile/android
ac_add_options --target=arm-linux-androideabi
ac_add_options --with-android-ndk=/var/tmp/dist/android-toolchain/android-ndk
ac_add_options --with-android-sdk=/var/tmp/dist/android-toolchain/android-sdk-linux
ac_add_options --with-gradle=/var/tmp/dist/android-toolchain/gradle/gradle-5.1.1/bin/gradle

# We do not use Tor Launcher on Android:
ac_add_options --disable-tor-launcher

if [ -z "${TB_BUILD_WITH_UPDATER}" ]; then
# Because Google Play will likely be the primary distribution medium,
# we disable updating and rely on Google Play by default. The
# Developer Policy explicitly prohibits in-app updating:
#    An app distributed via Google Play may not modify, replace, or
#    update itself using any method other than Google Plays update
#    mechanism.
# https://play.google.com/about/privacy-security-deception/malicious-behavior/

    ac_add_options --disable-tor-browser-update
    ac_add_options --disable-verify-mar
fi

ac_add_options --enable-strip
ac_add_options --disable-tests
ac_add_options --disable-debug
ac_add_options --disable-rust-debug
ac_add_options --disable-crashreporter
ac_add_options --disable-webrtc

ac_add_options --enable-proxy-bypass-protection

# Disable telemetry
ac_add_options MOZ_TELEMETRY_REPORTING=
```

Back to Bug 1636036 Comment 0